Conversation
Signed-off-by: Gimin Kim <138752849+Gimini-3@users.noreply.github.com>
Gimini-3
force-pushed
the
fix-form-encoder-configuration
branch
from
August 8, 2026 06:26
5464a4c to
4fe21fe
Compare
Gimini-3
marked this pull request as ready for review
August 8, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4330
What changed
HttpDataFactoryactually owns the created data.cleanOnTerminateJavadoc with its actual default.Failing regression coverage
Before the fix, the new tests demonstrate two observable setter-order failures:
They also verify that
cleanOnTerminate(false)survives charset, encoding, multipart, and factory-triggered rebuilds, and that both normal and callback-failure paths clean the configured custom factory.Scope
The production change is limited to HTTP client form configuration/rebuild and error cleanup:
HttpClientFormHttpClientFormEncoderHttpClientOperations.SendFormTests cover both the encoder directly and real HTTP form uploads.
Validation
HttpClientFormEncoderTests: 9 passedHttpClientWithTomcatTest: 15 passedcheckstyleMain,checkstyleTest, andspotlessCheck: passedreactor-netty-httpsuite: 2,888 tests executed; one unrelated SNI handshake-timeout test failed once and passed on isolated rerun