Repository navigation
Keep Tolk's model catalog out of the published config and merge a site's models into it by id (T11.6) - #2
Merged
Merged
Conversation
…e's models into it by id, so each update of Tolk brings its new models, prices and options to every site (T11.6)
afonic
added a commit
that referenced
this pull request
Oct 15, 2026
Keep Tolk's model catalog out of the published config and merge a site's models into it by id (T11.6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mergeConfigFrommerges top-level keys only. A site that publishedconfig/tolk.phpto change any value, concurrency for example, froze the whole model catalog: no later release of Tolk could add a model there or fix a price or a request option.1.0.0-beta.1's copy shows the cost. It sends Claude Haiku 5.5 the
between_toolsthinking option, which Anthropic refuses (T13.4), so Haiku calls fail on every site that published the config from beta.1.What changes
config/tolk.phptoresources/models.php, which only Tolk releases change.config/tolk.phpshipsmodels.anthropic,models.openaiandmodels.geminias empty lists.ModelCatalog::forProvider()merges a site's entries into Tolk's by id:optionsandpriceare replaced whole.RequestShapeTestread the config's list, which is now empty, so it passed without sending a request; it now reads the catalog.configuration.md(the catalog section, an example, and a note for configs published from 1.0.0-beta.1),troubleshooting.md, the Boost guideline andCHANGELOG.md, which tells beta.1 sites to delete their copiedmodelsentries or keep only the keys they changed.Tracked as T11.6 in
TASKS.md.Not in this PR
Checks
vendor/bin/pest --parallel: 3,345 passedvendor/bin/pint --test: cleannpm run cp:build: no change toresources/dist/buildtolk:doctorreports OK.