Repository navigation
RDKB-64441 : Trigger firewall restart on XDNS client entry add/delete/commit - #33
Open
rajkamal-cv wants to merge 1 commit into
Open
rajkamal-cv wants to merge 1 commit into
rajkamal-cv wants to merge 1 commit into
Conversation
…/commit Reason for change: DNSMappingTable add/delete/commit did not refresh firewall DNS redirect rules, so client-level XDNS tagging changes were not applied until a manual restart. Test Procedure: Add/delete DNSMappingTable entry, verify firewall rules update. Risks: Low Priority: P1 Signed-off-by: rajkamal_cv@comcast.com
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both notifications follow configuration updates and reuse the existing restart mechanism; the remaining regression-test suggestion is non-blocking.
1 open issue
What changed in this PR
Refreshes firewall DNS redirect rules when XDNS client mappings change, supporting the per-client redirects introduced by the related Utopia PR.
Changes:
- Requests a firewall restart after removing a client mapping.
- Requests a firewall restart after committing a new or updated mapping.
| File | Description |
|---|---|
source/dmlxdns/cosa_xdns_dml.c |
Adds firewall restart notifications after mapping deletion and commit. |
Review effort: Balanced
|
|
||
| /* XDNS firewall rules are per-client; refresh them so the new/updated | ||
| * client's DNS redirect rule is applied immediately (RDKB-64441) */ | ||
| commonSyseventSet("firewall-restart", ""); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-64441 : Trigger firewall restart on XDNS client entry add/delete/commit
Reason for change: DNSMappingTable add/delete/commit did not refresh firewall DNS redirect rules, so client-level XDNS tagging changes were not applied until a manual restart.
Test Procedure: Add/delete DNSMappingTable entry, verify firewall rules update. Risks: Low
Priority: P1
Signed-off-by: rajkamal_cv@comcast.com
Related PR - rdkcentral/utopia#462