Repository navigation
RDKB-67262: Remove Github token from Native build - #30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The external build scripts were unavailable, so compatibility with removing the token still requires verification.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the secret-backed GitHub token from the native-build workflow.
Changes:
- Removes the build step’s
GITHUB_TOKENenvironment variable referencingsecrets.RDKCM_RDKE.
| File | Description |
|---|---|
.github/workflows/native-build.yml |
Stops explicitly passing the token to the native build script. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SanthoshGujulvajagadeesh
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Remove GitHub token from native-build workflow.
Test Procedure: All checks should pass.
Risks: Low
Priority: P1
Signed-off-by: Sowmiya_Chelliah@comcast.com