Repository navigation
RDKEMW-26150: Make app cache replacement thread-safe - #222
Open
Kishoredarmaradje wants to merge 11 commits into
Open
Kishoredarmaradje wants to merge 11 commits into
Kishoredarmaradje wants to merge 11 commits into
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Dependency revision changes and compatibility-patch removals require native-build integration validation before approval.
No open issues 🎉
What changed in this PR
Makes application-cache replacement thread-safe by locking cache operations and returning copied entries to readers.
Changes:
- Adds synchronized replacement and copy-based lookups.
- Adds source-level guardrail checks for cache locking and usage.
- Updates build dependencies and revisions, removing compatibility patches.
| File | Description |
|---|---|
| tests/test_security_cache.py | Checks locking and copy-based lookup patterns. |
| server/plat/gdialobjCacheHelper.hpp | Adds mutex protection, replacement, and copied reads. |
| server/plat/gdialappcache.cpp | Uses replacement and copy-based lookup APIs. |
| build_dependencies.sh | Updates packages and dependency revisions; removes patches. |
Review effort: Balanced
added 5 commits
October 23, 2026 09:41
Comment on lines
+177
to
+181
| { | ||
| std::lock_guard<std::mutex> lock(dispatch->mutex); | ||
| dispatch->complete = true; | ||
| } | ||
| dispatch->condition.notify_one(); |
| g_source_attach(source, server_main_context); | ||
| g_source_unref(source); | ||
| std::unique_lock<std::mutex> lock(dispatch.mutex); | ||
| dispatch.condition.wait(lock, [&dispatch]{ return dispatch.complete; }); |
|
|
||
| GDialAppRegistry* gdial_app_registry_new (const gchar *app_name, const GList *app_prefixes, GHashTable *properties, gboolean is_singleton, gboolean use_additional_data, const GList *allowed_origins) { | ||
| g_return_val_if_fail(app_name != NULL, NULL); | ||
| g_return_val_if_fail(gdial_app_name_is_safe(app_name), NULL); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.