Repository navigation
RDKB-65516 : SSO - Local LAN Bypass - #228
Open
pavankumar464 wants to merge 1 commit into
Open
pavankumar464 wants to merge 1 commit into
pavankumar464 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The token callback bypasses the interface restriction, while the POST restriction rejects supported Ethernet/PON MSO access.
2 open issues
What changed in this PR
This PR aims to prevent local-LAN bypass of MSO single sign-on in the WebUI authentication handler.
Changes:
- Restricts MSO POST logins to the
cm_ipinterface classification. - Checks token type and segment count before JWT verification.
- Normalizes cable-modem interface addresses before comparison.
| File | Description |
|---|---|
source/Styles/xb3/jst/check.jst |
Adds login-interface restrictions, token format checks, and IP normalization. |
Review effort: Balanced
Comment on lines
+430
to
+431
| if ($cnt == 3) { | ||
| $tokenvalid = VerifyToken( $ADToken ); |
| if ($_POST["username"] == "mso") | ||
| { | ||
| if ($iface == "lan_ip" || $iface == "docsis_ip") { | ||
| if($iface != "cm_ip"){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: WebUI - SSO - Local LAN Bypass
Test Procedure: Test for WebUI access
Risks: Low
Priority: P1