Repository navigation
RDKB-67288 : myrouter.io redirection is not working eventhough secure webui is enabled - #227
Open
Thanusha-D wants to merge 2 commits into
Open
Thanusha-D wants to merge 2 commits into
Thanusha-D wants to merge 2 commits into
Conversation
… webui is enabled
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The expanded IPv6 discovery branch can clear the gateway address and produce malformed captive-portal redirects when no ULA is found.
1 open issue
What changed in this PR
Extends SecureWebUI redirection to Comcast devices so local access redirects to the configured hostname, such as myrouter.io, across the XB3 and XB6 interfaces.
Changes:
- Includes Comcast alongside Sky in IPv6 discovery and secure redirect handling.
- Adds local IPv6 detection to the XB6 template.
- Stops processing immediately after issuing secure redirects.
| File | Description |
|---|---|
source/Styles/xb6/jst/index.jst |
Extends partner handling, adds IPv6 detection, and terminates after redirects. |
source/Styles/xb3/jst/index.jst |
Extends partner handling and terminates after redirects. |
Review effort: Balanced
… webui is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: To route to myrouter.io when secure webui enabled
Test Procedure: Enable secure webui and check ui is redirecting to myrouter.io
Risks: Low
Priority: P1