Repository navigation
RDKB-67288 : myrouter.io redirection is not working eventhough secure… - #226
Closed
Thanusha-D wants to merge 1 commit into
Closed
Thanusha-D wants to merge 1 commit into
Thanusha-D wants to merge 1 commit into
Conversation
… webui is enabled
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both templates can clear the gateway IPv6 address when no ULA is found, producing malformed captive-portal redirects.
1 open issue
What changed in this PR
This PR updates the XB3 and XB6 login templates to address secure WebUI redirection for Comcast, including myrouter.io.
Changes:
- Extends secure WebUI redirect handling from Sky partners to Comcast.
- Stops page execution after sending secure redirects.
- Replaces the XB6 IPv6 helper call with inline address and port checks.
| File | Description |
|---|---|
source/Styles/xb6/jst/index.jst |
Extends partner handling, checks local IPv6 addresses inline, and exits after redirects. |
source/Styles/xb3/jst/index.jst |
Extends partner handling and exits after secure redirects. |
Review effort: Balanced
| $LanGwIP['ulaAddr'] = ''; | ||
| if(strpos($partnerId, "sky-") !== false) { | ||
| $secureWebUIRedirectPartner = (strpos($partnerId, "sky-") !== false) || !strcmp($partnerId, "comcast"); | ||
| if($secureWebUIRedirectPartner) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… webui is enabled