[sherik-sensin]

Reason for change: Marking table should be created dynamically based on the virtual interface marking entry from WanManager.

Test Procedure: Performed VLANManager Sanity test.
Risks: None.

Dependency:
rdkcentral/utopia#396
rdkcentral/wan-manager#223

[Copilot]

Pull request overview

Implements conditional compilation support for delegating L2 marking responsibilities to WanManager, aiming to keep VLANManager from applying QoS/marking configuration when FEATURE_WANMGR_L2_MARKING is enabled.

Changes:

• Skips calling EthLink_SetEgressQoSMap() during VLAN refresh when FEATURE_WANMGR_L2_MARKING is enabled.
• Skips creating/populating VLANManager’s internal marking table when FEATURE_WANMGR_L2_MARKING is enabled.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

source/TR-181/middle_layer_src/ethernet_apis.c:1082

• When FEATURE_WANMGR_L2_MARKING is enabled, the function currently skips all logic that clears/initializes pEntry->pstDataModelMarking and NumberofMarkingEntries, but still returns success. This can leave stale marking entries from previous runs/config and contradicts the intent of keeping VLANManager’s marking table empty when WanManager owns L2 marking.

#ifndef FEATURE_WANMGR_L2_MARKING /* WanManager owns L2 Marking */
    /* Marking table should be created dynamically based on the virtual interface marking entry from WanManager.  */
    /* But this is difficult, because the VlanManager's marking table is a static table. So keeping VlanManager's */
    /* marking table as empty and WanManager handles the QoS egress setting                                       */

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

source/TR-181/middle_layer_src/ethernet_apis.c:1124

• With FEATURE_WANMGR_L2_MARKING enabled, this function skips the marking-table rebuild but still returns success without clearing any existing pEntry->pstDataModelMarking / NumberofMarkingEntries. That can leave stale marking entries visible via EthLink_GetMarking() and contradicts the intent of keeping VLANManager’s marking table empty when WanManager owns L2 marking.

    CcspTraceInfo(("%s : Successfully Created EthLinkTable\n", __FUNCTION__));

#endif //FEATURE_WANMGR_L2_MARKING

source/TR-181/middle_layer_src/ethernet_apis.c:1083

• The block comment says VLANManager’s marking table should be kept empty because WanManager owns QoS egress, but it is inside the #ifndef FEATURE_WANMGR_L2_MARKING section (the branch where VLANManager does create/build the table). This is misleading and makes the conditional behavior harder to understand/maintain.

#ifndef FEATURE_WANMGR_L2_MARKING /* WanManager owns L2 Marking */
    /* Marking table should be created dynamically based on the virtual interface marking entry from WanManager.  */
    /* But this is difficult, because the VlanManager's marking table is a static table. So keeping VlanManager's */
    /* marking table as empty and WanManager handles the QoS egress setting                                       */

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[S-Parthiban-Selvaraj]

Can we keep this code if it is not causing any issue?
this will just mirror the value from the WanManager as what is applied currently to the Vlan