Repository navigation
Conversation
Release 2.4.1 2.4.1
Reason for change: Remove GitHub token from native-build workflow. Test Procedure: All checks should pass. Risks: Low Priority: P1 Signed-off-by: Sowmiya_Chelliah@comcast.com
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
4 open findings
GITHUB_TOKENmay break builds ifbuild_native.sh(or downstream steps)… · Newauto-changelog, but the content no longer matches an… · NewRDKB-66032 :vsRDKB-67262:).… · New
What changed in this PR
Updates release documentation and hardens CI by removing a secret token injection from the native build workflow.
Changes:
- Adds a new 2.5.0 section and prunes older auto-generated changelog content.
- Removes
GITHUB_TOKENsecret exposure from the native-build GitHub Actions workflow.
| File | Description |
|---|---|
| CHANGELOG.md | Replaces auto-generated compare-link sections with a condensed 2.5.0 entry and trims historical details |
| .github/workflows/native-build.yml | Removes passing a GitHub token secret into the native build step |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -29,5 +29,3 @@ jobs: | |||
| # Build component | |||
| chmod +x build_tools_workflows/cov_docker_script/build_native.sh | |||
| ./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)" | |||
| @@ -4,70 +4,23 @@ All notable changes to this project will be documented in this file. Dates are d | |||
|
|
|||
| Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). | |||
| #### [2.4.1](https://github.com/rdkcentral/tr069-protocol-agent/compare/2.4.0...2.4.1) | ||
| #### 2.5.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#38`](https://github.com/rdkcentral/tr069-protocol-agent/pull/38) |
| #### 2.5.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#38`](https://github.com/rdkcentral/tr069-protocol-agent/pull/38) | ||
| - RDKB-66032 : Add PR Format Check workflow [`#35`](https://github.com/rdkcentral/tr069-protocol-agent/pull/35) |
|
📋 PR Format Reminder
Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.5.0