Skip to content

RDKEMW-21092: Integrating cherrypick automation files - #63

Open
RajaLucy wants to merge 2 commits into
developfrom
feature/RDKEMW-21092
Open

RajaLucy wants to merge 2 commits into
developfrom
feature/RDKEMW-21092

Conversation

@RajaLucy

@RajaLucy RajaLucy commented Oct 9, 2026

Copy link
Copy Markdown

Reason for change: Integrating cherrypick automation workflow files.

Test Procedure: refer ticket.

Risks: Medium

Priority: P2

version: Patch

@RajaLucy
RajaLucy requested a review from a team as a code owner October 9, 2026 06:52
Copilot AI balanced review requested due to automatic review settings October 9, 2026 06:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Rebase merges can lose commits, concurrent runs can be canceled, and target parsing has correctness issues.

4 open findings
What changed in this PR

Adds automated validation and creation of backport pull requests.

Changes:

  • Validates and maps backport_to targets.
  • Cherry-picks merged changes onto target branches.
  • Creates backport PRs and reports conflicts.
File Description
.github/​workflows/​pr-validate-release.yml Validates requested backport targets.
.github/​workflows/​backport.yml Creates branches and PRs for backports.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/backport.yml
Comment thread .github/workflows/backport.yml
Comment thread .github/workflows/backport.yml
Comment thread .github/workflows/pr-validate-release.yml
Copilot AI balanced review requested due to automatic review settings October 9, 2026 12:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Parsing, concurrency, rerun idempotency, and token fallback issues can prevent or duplicate backports.

1 open finding
4 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Reruns create duplicate backport branches and PRs

.github/​workflows/​backport.yml:306

The workflow is not idempotent on rerun: once a previous attempt pushed feature/<TICKET>, this loop always skips it and selects a new suffix. The later existing-PR lookup checks only that newly selected head, so rerunning a successful or partially successful job can create duplicate branches and PRs. Use a deterministic name including the source PR and target, and resume/exit when its PR already exists.

🧠 Review effort: Balanced

Comment thread .github/workflows/backport.yml Outdated
@RajaLucy
RajaLucy force-pushed the feature/RDKEMW-21092 branch from 0a7a03e to 24f4c2d Compare October 15, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants