Skip to content

RDKB-64398: Fix for SNMP IPAddress set failure #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sriraaman-c wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKB-64398: Fix for SNMP IPAddress set failure #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/SnmpPlugin/ccsp_mib_definitions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
#define MAXI_DM_NAME_LENGTH 256
#define MAXI_CCSP_MAP_STRING_LEN 32
#define MAXI_MIB_DATA_TYPE_LEN 32
#define CCSP_MIB_IPV4_ADDRESS_SIZE 4

/* TR69 data type definition
*/
Expand Down
6 changes: 5 additions & 1 deletion source/SnmpPlugin/ccsp_mib_utilities.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,11 @@ CcspUtilInitMibValueArray
pMibValue->uSize = 6;

}
else if( pMibValue->uType >= ASN_IPADDRESS && pMibValue->uType <= ASN_OPAQUE)
else if( pMibValue->uType == ASN_IPADDRESS)
{
pMibValue->uSize = CCSP_MIB_IPV4_ADDRESS_SIZE;
Comment on lines +1737 to +1739
}
else if( pMibValue->uType > ASN_IPADDRESS && pMibValue->uType <= ASN_OPAQUE)
{
pMibValue->uSize = sizeof(ULONG);
}
Expand Down
6 changes: 5 additions & 1 deletion source/SnmpPlugin/ccsp_scalar_helper_access.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,11 @@ verifyTypeAndValueInSetReserved1
{
ret = netsnmp_check_vb_size(pVb, sizeof(BOOLEAN));
}
else if( nType == ASN_INTEGER || (nType >= ASN_IPADDRESS && nType <= ASN_OPAQUE))
else if( nType == ASN_IPADDRESS)
{
ret = netsnmp_check_vb_size(pVb, CCSP_MIB_IPV4_ADDRESS_SIZE);
Comment on lines +208 to +210
}
else if( nType == ASN_INTEGER || (nType > ASN_IPADDRESS && nType <= ASN_OPAQUE))
{
ret = netsnmp_check_vb_size(pVb, sizeof(ULONG));
}
Expand Down
6 changes: 5 additions & 1 deletion source/SnmpPlugin/ccsp_table_helper_access.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,11 @@ verifyTypeAndValueInSetReserved1
{
ret = netsnmp_check_vb_size(pVb, sizeof(BOOLEAN));
}
else if( nType == ASN_INTEGER || (nType >= ASN_IPADDRESS && nType <= ASN_OPAQUE))
else if( nType == ASN_IPADDRESS)
{
ret = netsnmp_check_vb_size(pVb, CCSP_MIB_IPV4_ADDRESS_SIZE);
Comment on lines +216 to +218
}
else if( nType == ASN_INTEGER || (nType > ASN_IPADDRESS && nType <= ASN_OPAQUE))
{
ret = netsnmp_check_vb_size(pVb, sizeof(ULONG));
}
Expand Down
Loading