Repository navigation
Conversation
Summary: Added support for getting text-sink in getSink method Type: Fix Test Plan: UT/CT, Fullstack Jira: VPLAY-12522
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves audio/video behavior and includes regression coverage for the subtitle sink’s synchronous flush setting.
No open issues 🎉
What changed in this PR
This PR enables the GStreamer player to retrieve subtitle sinks and read their async property when flushing subtitles, while preserving audio/video sink handling.
Changes:
- Add
text-sinklookup for subtitle sources without audio/video-specific sink unwrapping. - Separate test helpers for direct sink lookup and audio/video sink lookup.
- Add regression coverage for synchronous subtitle flushing.
| File | Description |
|---|---|
| tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerTest.cpp | Add subtitle flush coverage and update audio/video helper calls. |
| tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerPrivateTest.cpp | Update audio/video sink expectations to use the dedicated helper. |
| tests/unittests/media/server/gstplayer/genericPlayer/common/GstGenericPlayerTestCommon.h | Declare the audio/video helper and text-sink constant. |
| tests/unittests/media/server/gstplayer/genericPlayer/common/GstGenericPlayerTestCommon.cpp | Separate direct and audio/video sink expectation helpers. |
| media/server/gstplayer/source/GstGenericPlayer.cpp | Support subtitle sink lookup and bypass audio/video-specific handling. |
Review effort: Balanced
|
Coverage statistics of your commit: |
Summary: Added support for getting text-sink in getSink method
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: RDKEMW-27672