RDKEMW-26492: Workstream B1 implementation of Coarselock proposal by trupthi1403 · Pull Request #650 · rdkcentral/rialto

trupthi1403 · 2026-10-20T09:39:15Z

RDKEMW-26492: Workstream B1 implementation of Coarselock proposal

Reason for change: splitting NeedData locks per source and reducing cross-source contention
Test Procedure: UT/CT, Fullstack

github-actions · 2026-10-20T09:39:25Z

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
Detailed reason for change information
Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

rdkcmf-jenkins · 2026-10-20T09:43:28Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/650/rdkcentral/rialto
Commit: cfe175b

Report detail: gist'

Copilot

🟡 Changes recommended

A lock-order inversion can deadlock request processing, and notification insertion still introduces cross-source contention.

3 open issues

What changed in this PR

Implements Workstream B1 by splitting client NeedData locking by source type to reduce cross-source contention.

Changes:

Adds source-specific request buckets and shared routing metadata.
Uses shared locks for attached-source reads.
Adds a two-source request-routing test.

File	Description
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp	Tests independent audio/video request routing.
media/client/main/source/MediaPipeline.cpp	Implements request routing and per-source locking.
media/client/main/source/AttachedSources.cpp	Separates read and write locking.
media/client/main/include/MediaPipeline.h	Declares request buckets and locking helpers.
media/client/main/include/AttachedSources.h	Changes source protection to a shared mutex.

_{Review effort: Balanced}

github-actions · 2026-10-20T09:49:45Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-20T10:52:38Z

tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:43: warning: Access of moved variable 'audioWriter'. [accessMoved]
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:33: note: Calling std::move(audioWriter)
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:43: note: Access of moved variable 'audioWriter'.
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport]

rdkcmf-jenkins · 2026-10-20T10:53:42Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/650/rdkcentral/rialto
Commit: ba8d6b5

Report detail: gist'

Copilot

🟡 Changes recommended

Request insertion busy-waits on shared metadata, and concurrency test failure paths can hang.

4 open issues

2 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-10-20T11:03:30Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-20T11:10:52Z

tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:43: warning: Access of moved variable 'audioWriter'. [accessMoved]
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:33: note: Calling std::move(audioWriter)
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:500:43: note: Access of moved variable 'audioWriter'.
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport]

rdkcmf-jenkins · 2026-10-20T11:11:38Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/650/rdkcentral/rialto
Commit: 2e44820

Report detail: gist'

Copilot

🔵 Needs a closer look

The concurrency test’s timeout cleanup can deadlock, and request insertion introduces busy-wait contention.

2 open issues

2 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-10-20T11:22:23Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-20T11:36:06Z

tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:43: warning: Access of moved variable 'audioWriter'. [accessMoved]
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:33: note: Calling std::move(audioWriter)
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:43: note: Access of moved variable 'audioWriter'.
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport]

rdkcmf-jenkins · 2026-10-20T11:36:55Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/650/rdkcentral/rialto
Commit: 06797b4

Report detail: gist'

Copilot

🔵 Needs a closer look

Contention handling and concurrency-test timeout handling still need correction.

1 open issue

Release writeMutex before joining the audio thread

1 resolved since last review

Bound synchronous haveData call to prevent test hangs

_{Review effort: Balanced}

github-actions · 2026-10-20T11:42:11Z

tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:43: warning: Access of moved variable 'audioWriter'. [accessMoved]
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:33: note: Calling std::move(audioWriter)
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
tests/unittests/media/client/main/mediaPipeline/DataTest.cpp:498:43: note: Access of moved variable 'audioWriter'.
.WillOnce(Return(ByMove(std::move(audioWriter))))
^
nofile:0:0: information: Active checkers: 161/592 (use --checkers-report= to see details) [checkersReport]

Copilot

🟡 Changes recommended

Multi-source shutdown synchronization needs regression coverage to protect against shared-memory teardown during active writes.

1 open issue

Add shutdown regression test covering concurrent writes across all source bucke… · New

1 resolved since last review

Release writeMutex before joining the audio thread

_{Review effort: Balanced}

+    std::unique_lock<std::mutex> audioLock{m_needDataRequests[0].mutex};
+    std::unique_lock<std::mutex> videoLock{m_needDataRequests[1].mutex};
+    std::unique_lock<std::mutex> subtitleLock{m_needDataRequests[2].mutex};


github-actions · 2026-10-20T11:46:44Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

rdkcmf-jenkins · 2026-10-20T11:47:02Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/rialto/650/rdkcentral/rialto
Commit: 8f55ac1

Report detail: gist'

github-actions · 2026-10-20T11:53:35Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

rdkcmf-jenkins · 2026-10-20T14:58:30Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: Not a real code match
Commit: 8f55ac1
'

Copilot

🔵 Needs a closer look

The reported lock-contention and concurrency-test reliability issues remain unresolved in the supplied changes.

1 open issue

Add shutdown regression test covering concurrent writes across all source bucke…

_{Review effort: Balanced}

Reason for change: splitting NeedData locks per source and reducing cross-source contention Test Procedure: Build and Verify Priority: P0 Risks: Low

Copilot AI balanced review requested due to automatic review settings October 20, 2026 09:39

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 09:39

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread media/client/main/source/MediaPipeline.cpp Outdated

Comment thread media/client/main/source/MediaPipeline.cpp Outdated

Comment thread tests/unittests/media/client/main/mediaPipeline/DataTest.cpp

github-advanced-security Bot found potential problems Oct 20, 2026

View reviewed changes

Comment thread media/client/main/source/MediaPipeline.cpp Fixed

Copilot AI balanced review requested due to automatic review settings October 20, 2026 10:52

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 10:52

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread media/client/main/source/MediaPipeline.cpp

Comment thread tests/unittests/media/client/main/mediaPipeline/DataTest.cpp Outdated

Comment thread tests/unittests/media/client/main/mediaPipeline/DataTest.cpp

Copilot AI balanced review requested due to automatic review settings October 20, 2026 11:10

trupthi1403 force-pushed the feature/RDKEMW-26492-dev branch from ba8d6b5 to 2e44820 Compare October 20, 2026 11:10

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 11:10

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 20, 2026 11:35

trupthi1403 force-pushed the feature/RDKEMW-26492-dev branch from 2e44820 to 06797b4 Compare October 20, 2026 11:35

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 11:36

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 20, 2026 11:41

trupthi1403 force-pushed the feature/RDKEMW-26492-dev branch from 06797b4 to 8f55ac1 Compare October 20, 2026 11:41

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 11:42

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 22, 2026 10:07

trupthi1403 force-pushed the feature/RDKEMW-26492-dev branch from 8f55ac1 to d0c5cf6 Compare October 22, 2026 10:07

Copilot started reviewing on behalf of trupthi1403 October 22, 2026 10:08

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

trupthi1403 added 2 commits October 22, 2026 16:06

RDKEMW-26492: Workstream B1 implementation of Coarselock proposaL

93189ec

Reason for change: splitting NeedData locks per source and reducing cross-source contention Test Procedure: Build and Verify Priority: P0 Risks: Low

To resolve copilot comments and CI failures

6acc8ed

trupthi1403 force-pushed the feature/RDKEMW-26492-dev branch from d0c5cf6 to 6acc8ed Compare October 22, 2026 10:36

Conversation

trupthi1403 commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

rdkcmf-jenkins commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants