RDKEMW-26210: Workstream A implementation of Coarselock proposal by trupthi1403 · Pull Request #649 · rdkcentral/rialto

trupthi1403 · 2026-10-19T12:22:50Z

RDKEMW-26210: Workstream A implementation of Coarselock proposal

Reason for change: reduce IPC lock contention by making socket state atomic, splitting pending-call locking
Test Procedure: UT/CT, Fullstack

…arseLock Summary: reduce IPC lock contention by making socket state atomic, splitting pending-call locking, moving send paths out of global locks, and adding concurrent no-reply coverage Type: Fix Test Plan: UT/CT, Fullstack Jira: RDKEMW-26210

github-actions · 2026-10-19T12:23:05Z

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
Detailed reason for change information
Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

Copilot

🟡 Changes recommended

Unresolved socket-lifetime, receive-buffer, and callback-completion races can cause misdirected traffic, data corruption, and use-after-free.

6 open issues

What changed in this PR

Implements Workstream A to reduce IPC lock contention in client channels and server connections.

Changes:

Makes socket state atomic and separates pending-call locking.
Moves receive buffers to individual channels and narrows server lock scopes.
Adds concurrent no-reply request coverage.

File	Description
tests/unittests/ipc/IpcTest.cpp	Adds multithreaded no-reply request test.
ipc/server/source/IpcServerImpl.h	Makes client socket descriptors atomic.
ipc/server/source/IpcServerImpl.cpp	Updates socket lifecycle handling and send locking.
ipc/client/source/IpcChannelImpl.h	Separates pending-call locking and adds per-channel buffers.
ipc/client/source/IpcChannelImpl.cpp	Refactors socket access, receiving, and pending-call registration.

_{Review effort: Balanced}

github-actions · 2026-10-19T12:33:07Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🟡 Changes recommended

Pending calls can complete before transmission, and reentrant timeout callbacks can deadlock.

3 open issues

6 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-10-19T14:32:54Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🟡 Changes recommended

Concurrent receive processing can discard a valid reply when another thread handles socket closure.

2 open issues

2 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-10-19T15:36:52Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🟡 Changes recommended

Scheduling-dependent test failures, added logging overhead, and missing concurrent reply-path coverage remain unresolved.

5 open issues

1 resolved since last review

Serialize receive and dispatch to prevent lost replies

_{Review effort: Balanced}

    // copy in the actual message data
    std::string reqString = request->SerializeAsString();
    call->set_request_message(std::move(reqString));
+    const std::string kRequestDebugString = request->ShortDebugString();


+        MethodCall pendingCall = methodCall;
+        pendingCall.timeoutDeadline = std::chrono::steady_clock::time_point::max();

-        if (m_sock < 0)
-        {
-            errorMessage = "Not connected";
-        }
-        else if (sendmsg(m_sock, header, MSG_NOSIGNAL) != static_cast<ssize_t>(kRequiredDataLen))
+        std::lock_guard<std::mutex> locker(m_lock);
+        m_methodCalls.emplace(kSerialId, pendingCall);


+                for (int i = 0; i < kRequestsPerThread; ++i)
+                {
+                    if (!m_clientStub->sendSingleVarRequestWithNoReply(m_int))
+                    {
+                        allRequestsSucceeded.store(false, std::memory_order_relaxed);


github-actions · 2026-10-19T16:15:05Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

The revised synchronization and pending-call lifecycle require human validation of concurrent reply and disconnect behavior.

5 open issues

_{Review effort: Balanced}

github-actions · 2026-10-20T06:01:04Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

The concurrency-sensitive socket and pending-call lifecycle changes require human validation before approval.

3 open issues

1 resolved since last review

Lock remains held during debug formatting and logging

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

Performance regressions and missing concurrent reply-path coverage remain unresolved.

3 open issues

_{Review effort: Balanced}

github-actions · 2026-10-20T08:28:00Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-20T08:32:04Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot AI balanced review requested due to automatic review settings October 19, 2026 12:22

Copilot started reviewing on behalf of trupthi1403 October 19, 2026 12:23

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

github-advanced-security Bot found potential problems Oct 19, 2026

View reviewed changes

Comment thread ipc/client/source/IpcChannelImpl.cpp Fixed

Comment thread ipc/server/source/IpcServerImpl.cpp Fixed

Copilot AI balanced review requested due to automatic review settings October 19, 2026 14:21

Copilot started reviewing on behalf of trupthi1403 October 19, 2026 14:22

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread ipc/client/source/IpcChannelImpl.cpp Outdated

Comment thread ipc/client/source/IpcChannelImpl.cpp Outdated

Comment thread ipc/client/source/IpcChannelImpl.cpp Outdated

Copilot AI balanced review requested due to automatic review settings October 19, 2026 15:24

trupthi1403 force-pushed the feature/RDKEMW-26210-dev branch from 3cf4445 to 71a9147 Compare October 19, 2026 15:24

Copilot started reviewing on behalf of trupthi1403 October 19, 2026 15:24

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread ipc/client/source/IpcChannelImpl.cpp Outdated

Copilot AI balanced review requested due to automatic review settings October 19, 2026 16:03

trupthi1403 force-pushed the feature/RDKEMW-26210-dev branch from 71a9147 to b28af94 Compare October 19, 2026 16:03

Copilot started reviewing on behalf of trupthi1403 October 19, 2026 16:04

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 20, 2026 05:52

trupthi1403 force-pushed the feature/RDKEMW-26210-dev branch from b28af94 to fcea6da Compare October 20, 2026 05:52

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 05:53

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 20, 2026 08:16

trupthi1403 force-pushed the feature/RDKEMW-26210-dev branch from fcea6da to 2de867e Compare October 20, 2026 08:16

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 08:16

View session

To resolve copilot comments and CI failures

ea109cd

trupthi1403 force-pushed the feature/RDKEMW-26210-dev branch from 2de867e to ea109cd Compare October 20, 2026 08:21

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 20, 2026 08:21

Copilot started reviewing on behalf of trupthi1403 October 20, 2026 08:21

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Conversation

trupthi1403 commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants