RDKEMW-15487: Configure PlaybackInfo timer by VidhathriJoshi · Pull Request #647 · rdkcentral/rialto

VidhathriJoshi · 2026-10-16T07:14:31Z

RDKEMW-15487: Configure PlaybackInfo timer

Reason for change: Propagate the PlaybackInfo update interval through appmanagers and the Rialto server. Suppress duplicate periodic notifications while ensuring PAUSED transitions still report PlaybackInfo.

Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-15487

github-actions · 2026-10-16T07:14:43Z

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
Detailed reason for change information
Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

Copilot

🟡 Changes recommended

A duplicate protobuf field number blocks generation, outdated mocks block test compilation, and an existing timer test conflicts with duplicate suppression.

4 open findings

Fix timer notification test for duplicate suppression · New
Resolve duplicate protobuf field number · New
Implement playback timer getter in session mock · New
Update controller mock overload signatures · New

What changed in this PR

This PR passes an application-supplied playback-info timer interval through the server manager to the GStreamer player.

Changes:

Adds and forwards the timer setting, preserving it across server restarts.
Uses the configured interval with a 32 ms fallback.
Suppresses duplicate playback-info notifications and adds tests.

File	Description
tests/unittests/media/server/gstplayer/genericPlayer/GstGenericPlayerPrivateTest.cpp	Tests notification suppression and changed values.
serverManager/ipc/source/Controller.h	Extends configuration signatures.
serverManager/ipc/source/Controller.cpp	Forwards the timer interval.
serverManager/ipc/source/Client.h	Adds timer parameters.
serverManager/ipc/source/Client.cpp	Serializes nonzero intervals.
serverManager/ipc/include/IController.h	Extends the controller interface.
serverManager/common/source/SessionServerAppManager.cpp	Passes and preserves the interval.
serverManager/common/source/SessionServerApp.h	Declares interval storage and getter.
serverManager/common/source/SessionServerApp.cpp	Stores and exposes the interval.
serverManager/common/source/ISessionServerApp.h	Adds the interval getter contract.
proto/servermanagermodule.proto	Adds the configuration field.
media/server/ipc/source/ServerManagerModuleService.cpp	Exposes the interval through an environment variable.
media/server/gstplayer/source/GstGenericPlayer.cpp	Configures timing and suppresses duplicates.
media/server/gstplayer/include/GenericPlayerContext.h	Caches the last reported values.
common/public/include/SessionServerCommon.in	Adds the public application setting.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-10-17T19:39:30Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-19T10:50:28Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🟡 Changes recommended

Pause reporting races with periodic callbacks over shared cache state, and configured intervals lack targeted tests.

5 open issues

1 resolved since last review

Resolve duplicate protobuf field number

_{Review effort: Balanced}

github-actions · 2026-10-19T12:55:22Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-19T13:11:37Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Reason for change: to add a new property for passing the playbackinfo timer value from entservices->rialto YT specific configuration Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-15487 Co-authored-by: Vidhathri Joshi <vidhathri_joshi@comcast.com>

Summary: add a new property for passing the playbackinfo timer value fro entservices-appmanagers Type: Fix Test Plan: UT/CT, Fullstack Jira: RDKEMW-15487 Co-authored-by: Vidhathri Joshi <vidhathri_joshi@comcast.com>

Reason for change: Protect PlaybackInfo duplicate suppression from timer-thread races, preserve pause notifications, and verify configured interval propagation. Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-15487

github-actions · 2026-10-22T06:18:59Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🟡 Changes recommended

The central IPC-to-player configuration handoff lacks regression coverage for configured, absent, and zero intervals.

1 open issue

Add service tests for playback timer environment handoff and fallback · New

2 resolved since last review

_{Review effort: Balanced}

VidhathriJoshi force-pushed the feature/RDKEMW-15487_develop branch from fda3e67 to c3fed46 Compare October 16, 2026 07:18

VidhathriJoshi requested a balanced review from Copilot October 16, 2026 07:44

Copilot started reviewing on behalf of VidhathriJoshi October 16, 2026 07:45

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp Outdated

Comment thread proto/servermanagermodule.proto Outdated

Comment thread serverManager/common/source/ISessionServerApp.h

Comment thread serverManager/ipc/include/IController.h Outdated

VidhathriJoshi force-pushed the feature/RDKEMW-15487_develop branch from c3fed46 to bc8e2fe Compare October 16, 2026 08:16

naveendude15 force-pushed the feature/RDKEMW-15487_develop branch from 7c62c55 to 8f733b1 Compare October 19, 2026 10:39

naveendude15 requested a balanced review from Copilot October 19, 2026 11:11

Copilot started reviewing on behalf of naveendude15 October 19, 2026 11:12

View session

Copilot AI reviewed Oct 19, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp Outdated

Comment thread media/server/gstplayer/source/GstGenericPlayer.cpp

naveendude15 closed this Oct 19, 2026

naveendude15 reopened this Oct 19, 2026

github-actions Bot locked and limited conversation to collaborators Oct 19, 2026

naveendude15 changed the title ~~RDKEMW-15487: Adjusting Playback info timer~~ RDKEMW-15487: Configure PlaybackInfo timer Oct 19, 2026

rdkcentral unlocked this conversation Oct 19, 2026

VidhathriJoshi and others added 5 commits October 22, 2026 11:37

RDKEMW-15487: Adjusting Playback info timer

2f3491c

Summary: add a new property for passing the playbackinfo timer value fro entservices-appmanagers Type: Fix Test Plan: UT/CT, Fullstack Jira: RDKEMW-15487 Co-authored-by: Vidhathri Joshi <vidhathri_joshi@comcast.com>

RDKEMW-15487: Refine playback info timer

9a0ac80

RDKEMW-15487: Preserve pause PlaybackInfo notification

2f0393c

RDKEMW-15487: Synchronize PlaybackInfo timer notifications

cc4a756

Reason for change: Protect PlaybackInfo duplicate suppression from timer-thread races, preserve pause notifications, and verify configured interval propagation. Test Procedure: https://ccp.sys.comcast.net/browse/RDKEMW-15487

VidhathriJoshi force-pushed the feature/RDKEMW-15487_develop branch from 225c501 to cc4a756 Compare October 22, 2026 06:08

VidhathriJoshi marked this pull request as ready for review October 22, 2026 06:32

Copilot AI balanced review requested due to automatic review settings October 22, 2026 06:32

Copilot started reviewing on behalf of VidhathriJoshi October 22, 2026 06:32

View session

Copilot AI reviewed Oct 22, 2026

View reviewed changes

Comment thread media/server/ipc/source/ServerManagerModuleService.cpp

Conversation

VidhathriJoshi commented Oct 16, 2026 • edited by naveendude15 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

VidhathriJoshi commented Oct 16, 2026 •

edited by naveendude15

Loading