RDKEMW-26260: Workstream A - Polling Bus Dispatcher by Chirag-BN · Pull Request #640 · rdkcentral/rialto

Chirag-BN · 2026-10-15T11:18:05Z

RDKEMW-26260: Workstream A

Reason for change: Replace polling bus dispatcher with GMainLoop-based event-driven dispatcher (PeriodicWakes - Theme 6)
Test Procedure: Rialto CI

github-actions · 2026-10-15T11:23:47Z

Pull request title must follow the pattern:
< JIRA TICKET >: < one line summary of change less than 65 characters >

Pull request description must follow the Commit message format for RDK-E:
https://etwiki.sys.comcast.net/spaces/RDKAR/pages/1407997180/Commit+Message+Format+For+RDKE

Associated JIRA ticket in format : < JIRA TICKET >: < one line summary of change less than 65 characters >
Detailed reason for change information
Test procedure. Only references links to Jira ticket or sub tickets where test steps and references are captured.

< JIRA TICKET >: < one line summary of change less than 65 characters >
< empty line >
Reason for change:
Test Procedure: < https://ccp.sys.comcast.net/browse/JIRA TICKET/url/to/test_step_section>

Copilot

🟡 Changes recommended

Shutdown can hang before loop startup, and the component-test harness still depends on polling.

2 open findings

What changed in this PR

Replaces periodic GStreamer bus polling with a private GLib event loop to reduce idle wakeups.

Changes:

Adds bus-watch and main-loop wrapper APIs and mocks.
Injects the GLib wrapper into both player dispatchers.
Reworks dispatcher unit tests around callbacks and message ownership.

File	Description
wrappers/interface/IGstWrapper.h	Declares bus-watch and message-reference APIs.
wrappers/interface/IGlibWrapper.h	Declares context, loop, and source APIs.
wrappers/include/GstWrapper.h	Implements new GStreamer wrappers.
wrappers/include/GlibWrapper.h	Implements new GLib wrappers.
tests/unittests/media/server/mocks/gstplayer/GstDispatcherThreadFactoryMock.h	Updates factory mock signature.
tests/unittests/media/server/gstplayer/webAudioPlayer/CreateTest.cpp	Updates factory failure expectation.
tests/unittests/media/server/gstplayer/webAudioPlayer/common/GstWebAudioPlayerTestCommon.cpp	Updates dispatcher creation expectation.
tests/unittests/media/server/gstplayer/genericPlayer/common/GstGenericPlayerTestCommon.cpp	Updates dispatcher creation expectation.
tests/unittests/media/server/gstplayer/dispatcherThread/GstDispatcherThreadTest.cpp	Tests callback dispatch and lifecycle.
tests/common/externalLibraryMocks/GstWrapperMock.h	Mocks new GStreamer APIs.
tests/common/externalLibraryMocks/GlibWrapperMock.h	Mocks new GLib APIs.
media/server/gstplayer/source/GstWebAudioPlayer.cpp	Passes GLib wrapper to dispatcher.
media/server/gstplayer/source/GstGenericPlayer.cpp	Passes GLib wrapper to dispatcher.
media/server/gstplayer/source/GstDispatcherThread.cpp	Replaces polling with bus-watch dispatch.
media/server/gstplayer/include/IGstDispatcherThread.h	Extends factory interface.
media/server/gstplayer/include/GstDispatcherThread.h	Declares event-loop state and callbacks.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-10-15T11:33:41Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-15T11:49:27Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

Shutdown can block indefinitely if the quit request occurs before the dispatcher enters the main loop.

2 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-15T12:51:23Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

A startup/shutdown race can lose the quit request and block player teardown indefinitely.

2 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-15T16:36:35Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

Shutdown can lose an early quit request and block player destruction indefinitely.

2 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-15T17:10:38Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

The shutdown race and component-test harness incompatibility remain unresolved.

2 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-16T07:25:39Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

Shutdown can race loop startup and block player destruction indefinitely.

2 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-16T15:38:53Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

Thread shutdown and message ownership changes warrant human review and real-GLib validation because the updated tests simulate loop scheduling.

3 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-16T15:44:50Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

The threading and lifecycle rewrite needs human review and validation against real GLib scheduling beyond the mocked tests.

3 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-16T15:50:23Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot

🔵 Needs a closer look

Cross-thread shutdown and callback ownership need human validation against real GLib execution beyond the mocked tests.

3 open findings

🧠 Review effort: Balanced

github-actions · 2026-10-16T15:56:23Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

github-actions · 2026-10-16T15:58:41Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Reason for change: Replace polling bus dispatcher with GMainLoop-based event-driven dispatcher (PeriodicWakes - Theme 6) Test Procedure: Rialto CI Signed-off-by: cbicco888 <chirag_biccodenandeesh@comcast.com>

Copilot

🔵 Needs a closer look

Cross-thread shutdown and message ownership need human review alongside Rialto CI results, since the updated tests simulate GLib dispatch.

No open issues 🎉

3 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-10-23T12:56:41Z

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 84.5%
Functions coverage stays unchanged and is: 92.8%

Copilot AI balanced review requested due to automatic review settings October 15, 2026 11:18

Copilot started reviewing on behalf of Chirag-BN October 15, 2026 11:21

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread media/server/gstplayer/source/GstDispatcherThread.cpp

Comment thread media/server/gstplayer/source/GstDispatcherThread.cpp

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 0a29c80 to 2f2b910 Compare October 15, 2026 11:41

Copilot AI balanced review requested due to automatic review settings October 15, 2026 12:39

Copilot started reviewing on behalf of Chirag-BN October 15, 2026 12:40

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 15, 2026 16:24

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 5f8b18c to 4a74dc5 Compare October 15, 2026 16:24

Copilot started reviewing on behalf of Chirag-BN October 15, 2026 16:24

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 15, 2026 16:59

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 4a74dc5 to 5aa6b7d Compare October 15, 2026 16:59

Copilot started reviewing on behalf of Chirag-BN October 15, 2026 16:59

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 07:16

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 5aa6b7d to a116325 Compare October 16, 2026 07:16

Copilot started reviewing on behalf of Chirag-BN October 16, 2026 07:17

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 07:24

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from a116325 to 944d5fd Compare October 16, 2026 07:24

Copilot started reviewing on behalf of Chirag-BN October 16, 2026 07:25

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 15:39

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 3798da6 to cae6809 Compare October 16, 2026 15:39

Copilot started reviewing on behalf of Chirag-BN October 16, 2026 15:39

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 15:45

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from cae6809 to fda1c4b Compare October 16, 2026 15:45

Copilot started reviewing on behalf of Chirag-BN October 16, 2026 15:45

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 16, 2026 15:50

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from fda1c4b to 52b8970 Compare October 16, 2026 15:50

Copilot started reviewing on behalf of Chirag-BN October 16, 2026 15:50

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

skywojciechowskim requested changes Oct 23, 2026

View reviewed changes

skywojciechowskim approved these changes Oct 23, 2026

View reviewed changes

cbicco888 added 4 commits October 23, 2026 11:51

RDKEMW-26260: Workstream A

952dddb

Reason for change: Replace polling bus dispatcher with GMainLoop-based event-driven dispatcher (PeriodicWakes - Theme 6) Test Procedure: Rialto CI Signed-off-by: cbicco888 <chirag_biccodenandeesh@comcast.com>

ci-failure-fixes

e849049

valgrind-component-tests

c52b508

copilot-review-comments-fixes

7eed1e3

Copilot AI balanced review requested due to automatic review settings October 23, 2026 11:52

Chirag-BN force-pushed the feature/RDKEMW-26260 branch from 52b8970 to 7eed1e3 Compare October 23, 2026 11:52

Copilot started reviewing on behalf of Chirag-BN October 23, 2026 11:56

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

Chirag-BN merged commit 1d2c762 into master Oct 23, 2026
85 of 97 checks passed

github-actions Bot locked and limited conversation to collaborators Oct 23, 2026

Conversation

Chirag-BN commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Chirag-BN commented Oct 15, 2026 •

edited

Loading