Repository navigation
Conversation
Reason for change: Add firmware upgrade support in extender build Test Procedure: firmware upgrade should be successful for http and tftp in extender device after backhaul is connected Risks: None Priority: P1 Signed-off-by: ap934 <Akhil_P@comcast.com>
ap934
force-pushed
the
firmware_upgrade_extender
branch
from
August 10, 2026 09:49
c5419fe to
87b2f97
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds build-time support for EasyMesh extender firmware upgrade behavior by selecting a different “virtual” interface name at runtime when building for extender targets.
Changes:
- Adds
EXTENDER_ENABLEDbuild define inconfigure.ac(intended to be enabled for extender builds). - Updates
fwupgrade_hal_get_data_from_Xconf()to usebrlan0as the interface name whenEXTENDER_ENABLEDis set, instead of deriving WAN interface name from NVRAM/sysevent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/fwupgrade/fwupgrade_hal.c | Uses brlan0 for MAC derivation on extender builds (compile-time switch). |
| source/fwupgrade/configure.ac | Adds EXTENDER_ENABLED define to toggle extender-specific behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+823
to
829
| FILE *fp = NULL; | ||
| char g_virtualIfName[32] = "erouter0"; | ||
| #ifdef EXTENDER_ENABLED | ||
| strcpy(g_virtualIfName, "brlan0"); | ||
| #else | ||
| FILE *fp = fopen("/nvram/wan_name.txt", "r"); | ||
|
|
||
|
|
Comment on lines
+35
to
+37
| if test "x$EM_EXTENDER" = "xtrue"; then | ||
| AC_DEFINE([EXTENDER_ENABLED], [1], [Enable EM Extender support]) | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Add firmware upgrade support in extender build
Test Procedure: firmware upgrade should be successful for http and tftp in extender device after backhaul is connected
Risks: None
Priority: P1