Repository navigation
RDKEMW-24390,RDKB-66770: Stack buffer overflow in rdk_dyn_log_validate_component_name() via attacker-controlled comp_len - #62
Closed
dshett549 wants to merge 1 commit into
Conversation
…e_component_name() via attacker-controlled comp_len
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Datagram field bounds remain insufficiently validated, allowing out-of-bounds reads.
2 open findings
What changed in this PR
Adds a component-name length check to mitigate a stack buffer overflow in dynamic log control parsing.
Changes:
- Rejects component names that exceed the 64-byte buffer.
| File | Description |
|---|---|
src/rdk_dynamic_logger.c |
Adds component-name bounds checking. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Comment on lines
+78
to
+82
| if (comp_len >= sizeof(comp_name)) | ||
| { | ||
| fprintf(stderr, "Error: component name too long\n"); | ||
| return; | ||
| } |
Comment on lines
+78
to
+82
| if (comp_len >= sizeof(comp_name)) | ||
| { | ||
| fprintf(stderr, "Error: component name too long\n"); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.