RDKEMW-000: Fix Coverity defects (1 file) by rdkdevpilot · Pull Request #362 · rdkcentral/networkmanager

rdkdevpilot · 2026-09-15T15:19:17Z

Automated Fix for Coverity Defects

Triggered by: Devika Jaladi

Fixed Files

File	Line(s)	CIDs	Checker Types	Description
`plugin/NetworkManagerImplementation.cpp`	—	69144	PASS_BY_VALUE	Big parameter passed by value

Fix Summaries

plugin/NetworkManagerImplementation.cpp

The fix correctly addresses the PASS_BY_VALUE defect by changing the parameter from pass-by-value to rvalue reference (&&). The parameter 'newCache' is moved into the cache map at line 1807, which is the appropriate use of an rvalue reference. This eliminates the unnecessary copy of the IpFamilyCache object while preserving the existing logic. The change is minimal, does not introduce any new defects, and follows the acceptable fix pattern for PASS_BY_VALUE defects involving non-trivial types.

Reason for change: In the reported ticket, it is noticed that WiFi Plugin failed to subscribe `onAvailableSSIDs` event but didnt retry. So when scan is called by application, the scan was success but it never posted any update as it never received `onAvailableSSIDs` event from unified networkmanager plugin Test Procedure: As per DELIA-66411 Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: Implement RDKLogger Support to NetworkManager Plugin Test Procedure: Verify logs are printed properly Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: Additional Changes to support RDKLogger Test Procedure: Verify logs are printed properly Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

#1) Implemented a cache logic to handle redundant calls * update the review comments

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

…ate with NetworkManager (#21) Reason for change: Use ComRPC in Network and WiFi Plugin to communicate with NetworkManager Test Procedure: Perform all the Network and Wifi JSONRPC requests n confirm Risks: High Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

…gs (#23) Reason for change: Fixed the empty interface being returned in GetIPSettings Test Procedure: as per DELIA-66721 Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Reason for change: Fixed the empty IPAddress in onIPAddressChange Event Test Procedure: as per DELIA-66775 Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

* Added support for start WPS * Added support for start WPS

Reason for change: Check the empty interface & ipversion input Test Procedure: Call org.rdk.NetworkManager.GetIPSettings with no input param Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

* Implemented Test Class for wifisiganlstrength monitor class * Update CMakeLists.txt to include the unittest folder * Update gnome_unit_test.yml to upload the code coverage report --------- Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

…tAvailableInterfaces method (#31) * Gnome issue fix for following api wifiConnect addtoknownssid removeknowssid getavilablessid getwifisiganlstrength GetAvailableInterfaces GetPrimaryInterface GetInterfaceState GetIPSettings * onAddressChange event modified * Posting event even if interface already connected before plugin start * Update NetworkManagerGnomeEvents.cpp Signed-off-by: cmuhammedrafi <muhammed_rafi@comcast.com>

This reverts commit 04bce90.

…ceChanged EventData (#36) * The onWifiSignalThresholdChanged and onDefaultInterfaceChanged events are posted with empty/null event data. Fixing it * Updated the release version

Reason for change: GetInterfaceState is using the SetInterfaceState networkmanager implementation call instead of GetInterfaceState call. Modified the same. Test Procedure: Check with curl commands Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>

…bled before reboot (#38) -) set interface api updated -) onavailable ssid sterngth renamed -) removed unused variable

Signed-off-by: cmuhammedrafi <muhammed_rafi@comcast.com>

* DELIA-66920 - GetWiFiSignalStrength is not return actual strength Reason for change: Removed the internal mapping and returning the actual strength value Test Procedure: Check with curl command Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>

* RDKE-352 - Modified the WPS API Reason for change: Modified StartWPS API to use wpa_cli and wifiConnect API call to connect with wifi using WPS Test Procedure: Check with StartWPS curl command Risks: Low Priority: P1 Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>

…r IARM_BUS_NETWORK_MANAGER_EVENT_INTERFACE_IPADDRESS (#42)

…ead of integer (#43) Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Release of v0.5.4

Updated Wifi State

…ange. (#328) * onroutechange event implementation * Added macro to conditional compilation * Modified the code to have separate client to get connectivity status form the connectivity plugin * Added RFC for connectivity manager enabling in networkmanager * Added enable of USE_RFCAPI in proper place * updated with macro USE_CONNECTIVITYCHECKMGR * Added the documentation * Added Bridging of events between networkmanager and connectivity manager * Addressed the crash issue * To Fix the crash * Added reason for isconnectedtointernet API * Updated with compilation issue fix * Added cache logic to read the internet status from connectivitymgr plugin * Changed the reason into default instead of function overloading * Changed connected field to return true for LIMITED_INTERNET state only when connectivitymgr plugin is in use * Fixed compilation issue * Addressed copilot review comments * Addressed copilot review comments * Added more clarity to documentation for reason. Also added copilot review comments * Added reason to the oninternetstatuschange event * Addressed the review comment * Addressed copilot review comments * Addressed review comments * To fix L1 and L2 issue * For rdk proxy this test is not required * Update name of the RFC return code Update name of the RFC return code * Updated with review comments * Corrected variable name * Updated the missed change * Added header chrono * Fixed L1 and L2 issue * Fixed L1 and L2 issue * Change ConnectivityMonitor to non smart pointer to match old way * Fixed compilation issue * Addressed L1 test failure * To test * Removed unused code * Update NetworkManagerImplementation.cpp --------- Co-authored-by: Gururaaja E S R <Gururaja_ErodeSriranganRamlingham@comcast.com> Co-authored-by: RAFI <103924677+cmuhammedrafi@users.noreply.github.com> Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Release of 4.0.0

Reason for change: Remove explicit rescan request upon wake-up(NSM-ON). Test Procedure: Change the channel in AP or change the timeout for SAE GTK_REKEY when the box is in DeepSleep & wake-up; ensure WiFi reconnected with 10s; wake-up journey. Priority: P1 Risks: Low Signed-off-by: Devika Jaladi <djalad690@cable.comcast.com> Co-authored-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of 4.1.0

…3s to 1s (#345) * RDKEMW-23908: Reduce default ping count (3->1), timeout (3s->1s), interval (0.2s->0.002s) Reason for change: Current Ping method is synchronous and blocks other method calls while ping is executing. This fix is a mitigation. A proper fix requires methods like Ping that trigger long-running operations to be asynchronous. Test Procedure: Refer ticket Risks: Low Signed-off-by: Tony_Ukken2@comcast.com Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com> Co-authored-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of 4.2.0

Defect ID: 6e0dbd42-72b3-4b14-a740-56f0130fd7fb

Copilot

🟡 Changes recommended

The interface and callers must be updated consistently while preserving the caller’s cache data.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request attempts to fix Coverity defect 69144 by changing swapIpCache to accept an rvalue reference and avoid an unnecessary copy.

Changes:

Changes the newCache parameter in plugin/NetworkManagerImplementation.cpp from pass-by-value to rvalue reference.

File summaries

File	Review
`plugin/NetworkManagerImplementation.cpp`	The definition no longer matches the header declaration. Updating callers requires preserving cache data to avoid suppressing `IP_ACQUIRED` events.

Review details

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-advanced-security · 2026-09-15T15:24:18Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot

Copilot review overview

🟡 Changes recommended

The new rvalue-only swapIpCache API breaks existing lvalue call sites (notably in tests) and the GNOME events file now uses std::move without including <utility>, risking build failures.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 1 · 1

Open (4)

Preserve lvalue compatibility for swapIpCache callers · New
This change is not buildable as written: the class declaration in…
Include <utility> for std::move · New
Update PR metadata to reflect all modified files · New

Copilot

Copilot review overview

🟡 Changes recommended

The updated implementation performs a potentially expensive deep copy while holding m_ipCacheMutex, increasing lock contention compared to the prior by-value + move pattern.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 2

Open (4)

This change is not buildable as written: the class declaration in…
Avoid deep-copying IpFamilyCache while holding the mutex · New
Align PR description with swapIpCache implementation · New
Update PR metadata to reflect all modified files

Resolved since last review (2)

Preserve lvalue compatibility for swapIpCache callers
Include <utility> for std::move

Copilot

Copilot review overview

🟢 Approval recommended

The only remaining comment is a non-blocking metadata scope nit; the code changes are narrowly scoped and reviewed.

Review effort: Lite
Findings: 1

Open (1)

Align PR description with swapIpCache implementation

Resolved since last review (1)

Avoid deep-copying IpFamilyCache while holding the mutex

Copilot

🟡 Changes recommended

Update the pull request description and fixed-file summary to accurately reflect all modified files and functional changes.

1 open issue

Update PR description to include all modified files · New

_{Review effort: Lite}

                std::set<std::string> swapIpCache(const std::string& iface,
                                                  const std::string& ipFamily,
-                                                  IpFamilyCache newCache);
+                                                  IpFamilyCache&& newCache);


karuna2git and others added 30 commits October 4, 2024 18:56

DELIA-66446 : Implement RDKLogger Support to NetworkManager Plugin (#14)

a8541e8

Reason for change: Implement RDKLogger Support to NetworkManager Plugin Test Procedure: Verify logs are printed properly Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

DELIA-66446 : Implement RDKLogger Support to NetworkManager Plugin

be6a61d

Reason for change: Additional Changes to support RDKLogger Test Procedure: Verify logs are printed properly Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of v0.4.0

e55d0f0

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Updated the documentation for external interfaces (#18)

73885d0

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

DELIA-65737: Wi-Fi interface shows IP even after Wi-Fi is disconnected (

e1aa7f3

#1) Implemented a cache logic to handle redundant calls * update the review comments

Updated the documentation for external interfaces (#18)

77a3469

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

DELIA-66644 : Updated documentation & GetIPSettings return value (#22)

7d453e5

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

DELIA-66721 : Fixed the empty interface being returned in GetIPSettin…

3d3e3ac

…gs (#23) Reason for change: Fixed the empty interface being returned in GetIPSettings Test Procedure: as per DELIA-66721 Risks: Low Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

DELIA-66775 : Handle onIPAddressChange Event (#27)

84b4ba6

Reason for change: Fixed the empty IPAddress in onIPAddressChange Event Test Procedure: as per DELIA-66775 Risks: Medium Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

RDKE-352 - Add StartWPS in GNOME libnm (#28)

600bc9c

* Added support for start WPS * Added support for start WPS

Implement Fossid Scan to NetworkManager (#33)

6969691

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Release of v0.5.1 (#34)

3fda592

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>

Revert "Implement Fossid Scan to NetworkManager (#33)" (#35)

3d54c27

This reverts commit 04bce90.

DELIA-66876 : Fxing onWifiSignalThresholdChanged and onDefaultInterfa…

41834e2

…ceChanged EventData (#36) * The onWifiSignalThresholdChanged and onDefaultInterfaceChanged events are posted with empty/null event data. Fixing it * Updated the release version

RDKERDKE-353 WiFi is connected on bootup even if WiFi option was disa…

516986b

…bled before reboot (#38) -) set interface api updated -) onavailable ssid sterngth renamed -) removed unused variable

Release of v0.5.3 (#39)

9a456e3

Signed-off-by: cmuhammedrafi <muhammed_rafi@comcast.com>

Initialized IPstatus to lost in NetworkManagerInternalEventHandler fo…

9e0e915

…r IARM_BUS_NETWORK_MANAGER_EVENT_INTERFACE_IPADDRESS (#42)

Updated the json and documentation for signal strength as string inst…

cefc90f

…ead of integer (#43) Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

Release of v0.5.4

647c853

Release of v0.5.4

Updated Wifi State

3c2a140

Updated Wifi State

SetIPsettings stuck in Gmailoop (#49)

ca90b6c

Implement unit test file for connectivity and stun (#45)

37195eb

gururaajar and others added 7 commits September 3, 2026 10:50

Release of 4.0.0

a9ffe66

Release of 4.0.0

Release of 4.1.0

b9ae26d

Release of 4.1.0

Release of 4.2.0

f0292c9

Release of 4.2.0

Fix PASS_BY_VALUE in NetworkManagerImplementation.cpp

e980ed4

Defect ID: 6e0dbd42-72b3-4b14-a740-56f0130fd7fb

rdkdevpilot requested a review from a team as a code owner September 15, 2026 15:19

Copilot AI lite review requested due to automatic review settings September 15, 2026 15:19

rdkdevpilot added automated-fix pass_by_value labels Sep 15, 2026

Copilot started reviewing on behalf of rdkdevpilot September 15, 2026 15:19

View session

Copilot AI reviewed Sep 15, 2026

View reviewed changes

Comment thread plugin/NetworkManagerImplementation.cpp

Updated the devpilot fix

31b48f1

Copilot AI review requested due to automatic review settings September 21, 2026 03:01

Copilot started reviewing on behalf of rdkdevpilot September 21, 2026 03:01

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread plugin/NetworkManagerImplementation.h

Comment thread plugin/gnome/NetworkManagerGnomeEvents.cpp

Comment thread plugin/NetworkManagerImplementation.cpp

Updated the fix

af7f187

Copilot AI review requested due to automatic review settings September 21, 2026 03:18

Copilot started reviewing on behalf of rdkdevpilot September 21, 2026 03:18

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread plugin/NetworkManagerImplementation.cpp Outdated

Comment thread plugin/NetworkManagerImplementation.h Outdated

Updated the devpilot fix

2aee7a9

Copilot AI review requested due to automatic review settings September 23, 2026 02:13

Copilot started reviewing on behalf of rdkdevpilot September 23, 2026 02:14

View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

gururaajar requested a lite review from Copilot October 26, 2026 19:24

Copilot started reviewing on behalf of gururaajar October 26, 2026 19:24

View session

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Comment thread plugin/NetworkManagerImplementation.h

std::set<std::string> swapIpCache(const std::string& iface,

const std::string& ipFamily,

IpFamilyCache newCache);

IpFamilyCache&& newCache);

gururaajar changed the base branch from topic/coverity_check to develop October 26, 2026 19:28

Navigation Menu

Repository navigation

RDKEMW-000: Fix Coverity defects (1 file) - #362

RDKEMW-000: Fix Coverity defects (1 file)#362
rdkdevpilot wants to merge 272 commits into
developfrom
topic/RDKEMW-000

rdkdevpilot commented Sep 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-advanced-security AI commented Sep 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

rdkdevpilot commented Sep 15, 2026

Automated Fix for Coverity Defects

Fixed Files

Fix Summaries

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-advanced-security AI commented Sep 15, 2026

What Enabling Code Scanning Means:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants