Repository navigation
Conversation
Release 2.4.0 2.4.0
Reason for change: Remove GitHub token from native-build workflow. Test Procedure: All checks should pass. Risks: Low Priority: P1 Signed-off-by: Sowmiya_Chelliah@comcast.com
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
3 open findings
What changed in this PR
Updates release notes and hardens CI by removing a stored GitHub credential from the native build workflow.
Changes:
- Add a new
2.5.0section and adjust changelog entries. - Remove use of a repository secret token from
.github/workflows/native-build.yml.
| File | Description |
|---|---|
| CHANGELOG.md | Adds 2.5.0 notes but also alters/removes prior auto-generated changelog structure. |
| .github/workflows/native-build.yml | Drops injected GITHUB_TOKEN secret from the native build job. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -32,5 +32,3 @@ jobs: | |||
| # Build component | |||
| chmod +x build_tools_workflows/cov_docker_script/build_native.sh | |||
| ./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)" | |||
Comment on lines
+7
to
11
| #### 2.5.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#40`](https://github.com/rdkcentral/moca-agent/pull/40) | ||
| - RDKB-66032 : Add PR Format Check workflow [`#37`](https://github.com/rdkcentral/moca-agent/pull/37) | ||
| - RDKB-62906: Devices reporting non-moca clients to the moca interface [`#36`](https://github.com/rdkcentral/moca-agent/pull/36) |
| #### [2.4.0](https://github.com/rdkcentral/moca-agent/compare/2.3.0...2.4.0) | ||
| #### 2.5.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#40`](https://github.com/rdkcentral/moca-agent/pull/40) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.5.0