[rekhap2kandhavelan]

Reason for change: This fix addresses a CC sinkbin teardown issue where clearing a stale sinkbin reference could bypass the Rialto teardown sequence and leave its server-side session active.
The teardown paths now request GST_STATE_NULL, confirm the transition with bounded state polling, remove the sinkbin from the pipeline, and then clear retained references.
Test Procedure: updated in ticket
Risks: medium
Priority: P1
Signed-off-by: Rekha Kandhavelan rekha_kandhavelan@comcast.com

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

7 open issues

• On timeout, ConfigurePipeline() logs but continues reconfiguring the shared pipeline even though… · New
• Since std::mutex and std::condition_variable are now part of this public struct, ensure this… · New
• mTeardownInProgress is set at function entry, but clearing/notifying happens only at the bottom… · New
• The polling loop ignores the return value from gst_element_get_state(). If it returns… · New
• New behavior introduces bounded polling + a forced gst_element_set_state(..., NULL) fallback when… · New
• The if (current != GST_STATE_NULL) block is mis-indented relative to its surrounding scope, which… · New
• This mock sets pending to GST_STATE_NULL for the initial `gst_element_get_state(...,… · New

What changed in this PR

Fixes sinkbin teardown ordering and synchronization to prevent stale Rialto sessions (and resulting black screen/technical fault) after standby wake-up by ensuring sinkbins reach GST_STATE_NULL before removal/cleanup, and by preventing pipeline reconfiguration while teardown is still releasing resources.

Changes:

• Add teardown synchronization (mutex/CV + in-progress flag) to coordinate ConfigurePipeline() vs TearDownStream().
• Add bounded state polling after gst_element_set_state(..., GST_STATE_NULL) and force reset if NULL isn’t reached.
• Harden stale CC sinkbin cleanup paths and update the unit test to match the new teardown behavior.

File	Description
InterfacePlayerRDK.cpp	Adds teardown synchronization + bounded state polling and improves stale sinkbin teardown before clearing references.
InterfacePlayerPriv.h	Introduces shared teardown mutex/CV/flag in GstPlayerPriv to gate pipeline reconfiguration.
test/​utests/​tests/​InterfacePlayerTests/​InterfacePlayerFunctionTests.cpp	Updates expectations to reflect additional gst_element_get_state() polling during teardown.

_{Review effort: Lite}