Repository navigation
RDKEMW-27811 : [PLI]- [ROGERS IUV2][VIPA]Black Screen and Technical Fault Message on linear channel After Standby Wake-Up due to PlayerRequestTimeOut error - #313
Closed
rekhap2kandhavelan wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Configuration can still overlap teardown, and the added polling conflicts with existing unit-test expectations.
4 open issues
What changed in this PR
This PR addresses stale closed-caption sinkbins that can leave Rialto server sessions active by explicitly tearing them down before clearing references.
Changes:
- Request
GST_STATE_NULLand poll with bounded retries before removing sinkbins. - Add cleanup for stale closed-caption sinkbins during teardown and setup.
- Introduce synchronization intended to delay configuration while teardown is active.
| File | Description |
|---|---|
| InterfacePlayerRDK.cpp | Adds sinkbin cleanup, state polling, and teardown/configuration coordination. |
| InterfacePlayerPriv.h | Adds a mutex, condition variable, and teardown-in-progress flag. |
Review effort: Balanced
Comment on lines
+343
to
+345
| std::unique_lock<std::mutex> teardownLock(interfacePlayerPriv->gstPrivateContext->mTeardownMutex); | ||
| if (!interfacePlayerPriv->gstPrivateContext->mTeardownCV.wait_for(teardownLock, std::chrono::milliseconds(3000), | ||
| [this]{ return !interfacePlayerPriv->gstPrivateContext->mTeardownInProgress; })) |
| if (!interfacePlayerPriv->gstPrivateContext->mTeardownCV.wait_for(teardownLock, std::chrono::milliseconds(3000), | ||
| [this]{ return !interfacePlayerPriv->gstPrivateContext->mTeardownInProgress; })) | ||
| { | ||
| MW_LOG_ERR("InterfacePlayerRDK::ConfigurePipeline: timed out waiting for prior TearDownStream to complete"); |
| { | ||
| MW_LOG_ERR("InterfacePlayerRDK::ConfigurePipeline: timed out waiting for prior TearDownStream to complete"); | ||
| } | ||
| } |
| gint retryCnt = GST_ELEMENT_GET_STATE_RETRY_CNT_MAX; | ||
| do | ||
| { | ||
| (void)gst_element_get_state(GST_ELEMENT(stream->sinkbin), ¤t, &pending, 100 * GST_MSECOND); |
…re clearing a stale sinkbin reference could bypass the Rialto teardown sequence and leave its server-side session active. The teardown paths now request GST_STATE_NULL, confirm the transition with bounded state polling, remove the sinkbin from the pipeline, and then clear retained references. Test Procedure: updated in ticket Risks: medium Priority: P1 Signed-off-by: Rekha Kandhavelan rekha_kandhavelan@comcast.com
rekhap2kandhavelan
force-pushed
the
feature/RDKEMW-24866
branch
from
October 27, 2026 08:58
ddda5ef to
359b2a2
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Overlapping teardowns can release waiting configuration prematurely, and the stale closed-caption cleanup path lacks regression coverage.
6 open issues
Review effort: Balanced
rekhap2kandhavelan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…re clearing a stale sinkbin reference could bypass the Rialto teardown sequence and leave its server-side session active.
The teardown paths now request GST_STATE_NULL, confirm the transition with bounded state polling, remove the sinkbin from the pipeline, and then clear retained references. Test Procedure: updated in ticket
Risks: medium
Priority: P1
Signed-off-by: Rekha Kandhavelan rekha_kandhavelan@comcast.com