Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The BlueZ preference uses an incorrect variable name, so the intended version selection is ineffective.
1 open finding
What changed in this PR
Brings the missing Bluetooth configuration from PR #604 into the Banana Pi layer and documents existing GPLv3 exceptions.
Changes:
- Masks legacy BlueZ recipes for Kirkstone non-extender builds.
- Adds intended BlueZ version preferences for Kirkstone.
- Adds comments explaining existing tar and elfutils license exceptions.
| File | Description |
|---|---|
| conf/include/rdk-bpi-bbmasks.inc | Adds conditional BlueZ masks and license-exception comments. |
| conf/distro/include/rdk-bpi.inc | Adds intended BlueZ 5.82/5.66 version selection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| SECURITY_FORTIFY:pn-ccsp-xdns = "-Wno-error=unused-result" | ||
|
|
||
| PREFERRED_VERSION:bluez5:kirkstone = "${@bb.utils.contains('DISTRO_FEATURES', 'em_extender', '5.66', '5.82',d)}" |
SsandhyaR
approved these changes
Oct 17, 2026
SsandhyaR
merged commit Oct 21, 2026
f36c6fb
into
rdkcentral:feature-rdkb-wrynose-main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring changes from #604
Add comment to support GPLv3 exception approval