Repository navigation
Conversation
SsandhyaR
force-pushed
the
changes_wrt_main_filogic
branch
from
October 16, 2026 07:28
8dc850a to
be59946
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Invalid inline Python in the sysint service override blocks broadband builds when expanded.
1 open finding
What changed in this PR
Updates Banana Pi R4 gateway build integration for Kirkstone and Wrynose with the latest Filogic MP-4.3 SDK.
Changes:
- Refreshes SDK revisions, setup selection, and recipe adjustments.
- Updates HAL sources and sysint installation behavior.
- Configures FIT kernel images and adjusts kernel QA handling.
| File | Description |
|---|---|
| setup-environment-refboard-rdkb | Updates SDK setup and pattern-based recipe edits. |
| meta-rdk-mtk-bpir4/recipes-rdkb/sysint-broadband/sysint-broadband.bbappend | Adjusts sources, script removal, and service configuration. |
| meta-rdk-mtk-bpir4/recipes-kernel/linux/linux-mediatek_%.bbappend | Replaces empty-directory cleanup with a QA adjustment. |
| meta-rdk-mtk-bpir4/recipes-ccsp/hal/hal-wifi-generic_git.bbappend | Updates Kirkstone source layout and build directory. |
| meta-rdk-mtk-bpir4/recipes-ccsp/hal/hal-platform-generic_git.bbappend | Simplifies source revision selection. |
| meta-rdk-mtk-bpir4/recipes-ccsp/hal/hal-fwupgrade.bbappend | Updates the upstream source removal entry. |
| conf/machine/bananapi4-rdk-broadband.conf | Configures FIT kernel images for gateways. |
| conf/machine/bananapi4-rdk-broadband-ap-extender.conf | Configures FIT kernel images for extenders. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| then | ||
| cd ${_TOPDIR}/meta-filogic | ||
| git checkout 77e17792f60279b6e1deb1f1c6abf5705972bc6f | ||
| git checkout 01f7d0b641fdf230fe1120870afe419ef4a9257b |
SsandhyaR
force-pushed
the
changes_wrt_main_filogic
branch
from
October 16, 2026 07:57
be59946 to
91cf12b
Compare
SsandhyaR
force-pushed
the
changes_wrt_main_filogic
branch
from
October 16, 2026 11:58
91cf12b to
10c3497
Compare
Reason for change: Fixes for handling build on top of update filogic for both kirkstone and wrynose , currently supports on MP-4.3 Test Procedure: Build the gw wrt kirkstone and wrynose Risks: None Signed-off-by: ssiras826 <sandhyarani_sirasanagandla@comcast.com>
SsandhyaR
force-pushed
the
changes_wrt_main_filogic
branch
from
October 16, 2026 12:00
10c3497 to
5ab8b27
Compare
Comment on lines
+3
to
+6
| SRC_URI_append:kernel6-6 = " \ | ||
| ${CMF_GIT_ROOT}/rdkb/devices/raspberrypi/hal;protocol=${CMF_GIT_PROTOCOL};branch=${CMF_GIT_BRANCH};destsuffix=git/source/wifi/devices_bpi;name=wifihal-bananapi \ | ||
| " | ||
| SRC_URI_append:kernel6-12 = " \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixes for handling build on top of update filogic for both kirkstone and wrynose , currently supports on MP-4.3
Test Procedure: Build the gw wrt kirkstone and wrynose
Risks: None