Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
BuildFromTip mesh and non-mesh gateways still receive identical image names, preventing CI from distinguishing them.
1 open finding
What changed in this PR
Updates Banana Pi firmware naming so CI can identify EasyMesh controller and BuildFromTip builds.
Changes:
- Adds feature-dependent gateway image names.
- Adds a BuildFromTip-specific extender image name.
| File | Description |
|---|---|
| conf/machine/bananapi4-rdk-broadband.conf | Selects gateway names using EasyMesh and BuildFromTip features. |
| conf/machine/bananapi4-rdk-broadband-ap-extender.conf | Distinguishes BuildFromTip extender images. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Looks good to me. |
…rom regular gateway build for CI Reason for change : Added changes to have different firmware names to identify the mesh vs non-mesh GW builds . Also, added changes to identify the BuildFromTip firmware names as well. Test Procedure: Build successful Risks: Low Signed-off-by: Keerthana Pandurangan <keerthana_pandurangan@comcast.com>
kpandu987
force-pushed
the
RDKBACCL-2224
branch
from
October 16, 2026 14:27
ae1db3b to
e7b8769
Compare
| require conf/distro/include/rdk-bpi.inc | ||
| PREFERRED_PROVIDER_hal-wifi_onewifi = "hal-wifi-generic" | ||
|
|
||
| MACHINE_IMAGE_NAME = "${@bb.utils.contains('DISTRO_FEATURES','BuildFromTip','rdkb-generic-ci-em-ctrl-broadband-image', bb.utils.contains('DISTRO_FEATURES','EasyMesh','rdkb-generic-em-ctrl-broadband-image','rdkb-generic-broadband-image',d),d)}" |
cpokuru
reviewed
Oct 16, 2026
| require conf/distro/include/rdk-bpi.inc | ||
| PREFERRED_PROVIDER_hal-wifi_onewifi = "hal-wifi-generic" | ||
|
|
||
| MACHINE_IMAGE_NAME = "${@bb.utils.contains('DISTRO_FEATURES','BuildFromTip','rdkb-generic-ci-em-ctrl-broadband-image', bb.utils.contains('DISTRO_FEATURES','EasyMesh','rdkb-generic-em-ctrl-broadband-image','rdkb-generic-broadband-image',d),d)}" |
Contributor
There was a problem hiding this comment.
have you checked Device.DeviceInfo.SoftwareVersion
Contributor
Author
There was a problem hiding this comment.
Yes.. Tested and attached test results in JIRA
https://jira.rdkcentral.com/jira/browse/RDKBACCL-2224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : Added changes to have different firmware names to identify the mesh vs non-mesh GW builds .
Also, added changes to identify the BuildFromTip firmware names as well.
Test Procedure: Validated the all combinations of builds
Risks: Low