Repository navigation
Conversation
…ebugger TELEMETRY-36 : Decouple webconfig buildtime dependencies for remote debugger Reason for change: Decoupling Webconfig for platforms which dont support webconfig Test Procedure: Build and flash the image ,validate remote debugger using webpa and dmcli commands Risks: None Priority : P2
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
WebConfig is disabled unconditionally, including builds that enable the webconfig_bin feature.
Review effort: Balanced
Findings: 1
What changed in this PR
Decouples Remote Debugger from WebConfig on unsupported platforms.
Changes:
- Removes the WebConfig framework dependency.
- Defines
DISABLE_WEBCONFIGduring compilation.
| File | Description |
|---|---|
meta-rdk-mtk-bpir4/recipes-extended/remotedebugger/remotedebugger.bbappend |
Disables Remote Debugger’s WebConfig integration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ebugger
TELEMETRY-36 : Decouple webconfig buildtime dependencies for remote debugger
Reason for change: Decoupling Webconfig for platforms which dont support webconfig
Test Procedure: Build and flash the image ,validate remote debugger using webpa and dmcli commands
Risks: None
Priority : P2