Repository navigation
Conversation
Release 2.10.1 2.10.1
…an empty string value (#48) Reason for change: Webui page with url "mac_ssid=&" and "mac_ssid" shows 500 Internal Server Error Test Procedure: Test for mac_ssid URL inputs in wireless_network_configuration.jst Risks: Low Priority: P1
Reason for change: Remove GitHub token from native-build workflow. Test Procedure: All checks should pass. Risks: Low Priority: P1 Signed-off-by: Sowmiya_Chelliah@comcast.com
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
4 open findings
This test validates the expected value formac_ssid, but it doesn't assert the newly intended… · New This test validates the expected value formac_ssid, but it doesn't assert the newly intended… · New This test validates the expected value formac_ssid, but it doesn't assert the newly intended… · New Changelog entry uses 'Github' instead of the correct 'GitHub', and the issue key formatting is… · New
What changed in this PR
Updates the $_GET query-string parsing logic to be more tolerant of trailing & and valueless parameters, adds regression coverage, and removes a GitHub token from the native build workflow.
Changes:
- Make
$_GETparsing skip empty&segments and treat missing=as an empty string value. - Add a new C++ regression test for
QUERY_STRINGedge cases (mac_ssid=&andmac_ssid). - Remove
GITHUB_TOKENinjection from the native build GitHub Actions workflow and update the changelog.
| File | Description |
|---|---|
| tests/parser_test.cpp | Adds regression test covering tolerant $_GET parsing for trailing & and missing =. |
| tests/parser/jst_prefix.js | Updates test fixture prefix to skip empty segments and allow valueless params. |
| tests/parser/jst_parser_template_block_string.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_template_block_content.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_skip_whitespace.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_single_quotes.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_line_feeds.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_unknown.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_runtime.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_once.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_not_if_in_line_comment.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_not_if_in_content.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_not_if_in_block_comment.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_nested.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_malformed_1.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_code_before.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_include_code_after.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_comment_tag.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| tests/parser/jst_parser_backslash.jst.parsed | Updates parsed snapshot to match new $_GET parsing behavior. |
| jsts/jst_prefix.js | Updates shipped prefix logic for tolerant $_GET parsing. |
| CHANGELOG.md | Bumps release header and records recent PRs/commits. |
| .github/workflows/native-build.yml | Removes passing a repo secret token into native build jobs. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ASSERT_NE(ctx, nullptr); | ||
| evaluatePrefixWithRequestData(ctx, nullptr, nullptr); | ||
|
|
||
| EXPECT_TRUE(evaluateJavaScriptBoolean(ctx, "$_GET.mac_ssid === ''")); |
|
|
||
| duk_destroy_heap(ctx); | ||
|
|
||
| query_string_guard.set("mac_ssid"); |
| ASSERT_NE(ctx2, nullptr); | ||
| evaluatePrefixWithRequestData(ctx2, nullptr, nullptr); | ||
|
|
||
| EXPECT_TRUE(evaluateJavaScriptBoolean(ctx2, "$_GET.mac_ssid === ''")); |
| - RDKB-67262: Remove Github token from Native build [`#49`](https://github.com/rdkcentral/javascript-templates/pull/49) | ||
| - RDKB-67070 : In $_GET Skip empty segments and treat a missing '=' as an empty string value [`#48`](https://github.com/rdkcentral/javascript-templates/pull/48) |
|
📋 PR Format Reminder
Expected: |
|
I have read the CLA Document and I hereby sign the CLA 3 out of 4 committers have signed the CLA. |


Release 2.11.0