Skip to content

Release 2.11.0 - #50

Closed
bunnam988 wants to merge 4 commits into
mainfrom
release/2.11.0
Closed

bunnam988 wants to merge 4 commits into
mainfrom
release/2.11.0

Conversation

@bunnam988

Copy link
Copy Markdown
Contributor

Release 2.11.0

Release Agent and others added 4 commits September 21, 2026 06:43
Release 2.10.1 2.10.1
…an empty string value (#48)

Reason for change: Webui page with url "mac_ssid=&" and "mac_ssid" shows
500 Internal Server Error
Test Procedure: Test for mac_ssid URL inputs in
wireless_network_configuration.jst
Risks: Low
Priority: P1
Reason for change: Remove GitHub token from native-build workflow.
Test Procedure: All checks should pass.
Risks: Low
Priority: P1
Signed-off-by: Sowmiya_Chelliah@comcast.com
Copilot AI balanced review requested due to automatic review settings October 12, 2026 06:22
@bunnam988
bunnam988 requested a review from a team as a code owner October 12, 2026 06:22
Copilot stopped reviewing on behalf of bunnam988 due to an error October 12, 2026 06:22
@bunnam988 bunnam988 closed this Oct 12, 2026
@bunnam988
bunnam988 deleted the release/2.11.0 branch October 12, 2026 06:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

4 open findings
What changed in this PR

Updates the $_GET query-string parsing logic to be more tolerant of trailing & and valueless parameters, adds regression coverage, and removes a GitHub token from the native build workflow.

Changes:

  • Make $_GET parsing skip empty & segments and treat missing = as an empty string value.
  • Add a new C++ regression test for QUERY_STRING edge cases (mac_ssid=& and mac_ssid).
  • Remove GITHUB_TOKEN injection from the native build GitHub Actions workflow and update the changelog.
File Description
tests/​parser_test.cpp Adds regression test covering tolerant $_GET parsing for trailing & and missing =.
tests/​parser/​jst_prefix.js Updates test fixture prefix to skip empty segments and allow valueless params.
tests/​parser/​jst_parser_template_block_string.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_template_block_content.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_skip_whitespace.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_single_quotes.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_line_feeds.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_unknown.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_runtime.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_once.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_not_if_in_line_comment.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_not_if_in_content.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_not_if_in_block_comment.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_nested.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_malformed_1.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_code_before.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_include_code_after.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_comment_tag.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
tests/​parser/​jst_parser_backslash.jst.parsed Updates parsed snapshot to match new $_GET parsing behavior.
jsts/​jst_prefix.js Updates shipped prefix logic for tolerant $_GET parsing.
CHANGELOG.md Bumps release header and records recent PRs/commits.
.github/​workflows/​native-build.yml Removes passing a repo secret token into native build jobs.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/parser_test.cpp
ASSERT_NE(ctx, nullptr);
evaluatePrefixWithRequestData(ctx, nullptr, nullptr);

EXPECT_TRUE(evaluateJavaScriptBoolean(ctx, "$_GET.mac_ssid === ''"));
Comment thread tests/parser_test.cpp

duk_destroy_heap(ctx);

query_string_guard.set("mac_ssid");
Comment thread tests/parser_test.cpp
ASSERT_NE(ctx2, nullptr);
evaluatePrefixWithRequestData(ctx2, nullptr, nullptr);

EXPECT_TRUE(evaluateJavaScriptBoolean(ctx2, "$_GET.mac_ssid === ''"));
Comment thread CHANGELOG.md
Comment on lines +9 to +10
- RDKB-67262: Remove Github token from Native build [`#49`](https://github.com/rdkcentral/javascript-templates/pull/49)
- RDKB-67070 : In $_GET Skip empty segments and treat a missing '=' as an empty string value [`#48`](https://github.com/rdkcentral/javascript-templates/pull/48)
@github-actions

Copy link
Copy Markdown

📋 PR Format Reminder

  • Title: Release 2.11.0 — expected TICKET-123 : description
    (Multiple tickets OK: RDKCOM-5492 RDKBDEV-3336 : ... | Include US ticket + subtask for user-stories)
  • Description missing:
    • Reason for change
    • Test Procedure
    • Risks (Low / Medium / High)
    • Priority (P0 / P1 / P2)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


3 out of 4 committers have signed the CLA.
✅ pavankumar464
✅ sowmiyachelliah
✅ bunnam988
❌ Release Agent
Release Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants