Skip to content

RDKB-67262: Remove Github token from Native build - #49

Merged
SanthoshGujulvajagadeesh merged 2 commits into
developfrom
feature/RDKB-67262
Oct 8, 2026
Merged

SanthoshGujulvajagadeesh merged 2 commits into
developfrom
feature/RDKB-67262

Conversation

@sowmiyachelliah

Copy link
Copy Markdown
Contributor

Reason for change: Remove GitHub token from native-build workflow.
Test Procedure: All checks should pass.
Risks: Low
Priority: P1
Signed-off-by: Sowmiya_Chelliah@comcast.com

Copilot AI balanced review requested due to automatic review settings October 7, 2026 09:45
@sowmiyachelliah
sowmiyachelliah requested a review from a team as a code owner October 7, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The same token remains configured in two other native-build workflow jobs.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Removes a GitHub token from one native-build job.

Changes:

  • Removes RDKCM_RDKE from the push build environment.
File Description
.github/​workflows/​native-build.yml Removes the token from the push native-build step.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/native-build.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The targeted secret references are removed without affecting workflow structure.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@SanthoshGujulvajagadeesh
SanthoshGujulvajagadeesh merged commit e3b2b24 into develop Oct 8, 2026
16 checks passed
@SanthoshGujulvajagadeesh
SanthoshGujulvajagadeesh deleted the feature/RDKB-67262 branch October 8, 2026 07:08
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants