Repository navigation
RDKB-67402: [Coverity] Fix High and Medium Priority issues in hotspot… - #74
Deepak-Rathn wants to merge 1 commit into
Conversation
… component Reason for change: Fixing Coverity issue linked in Jira Test Procedure: Should meet Acceptance Criteria: Risks: Medium Priority: P1 Signed-off-by: Deepak-Rathn <deepak.rathn@gmail.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
🔵 Needs a closer look
The tunnel-signaling synchronization changes need concurrency and failover validation before approval.
No open issues 🎉
What changed in this PR
This PR addresses Coverity findings in the hotspot component, focusing on tunnel-signal synchronization, sysevent error handling, and resource cleanup.
Changes:
- Protect primary and secondary tunnel-signal consumption with a mutex and explicitly mask the checksum result.
- Check sysevent return values in hotspot disable and MAP-T address lookup paths.
- Reset the ARP daemon’s sysevent descriptor and token after closing the connection.
| File | Description |
|---|---|
| source/hotspotfd/hotspotfd.c | Synchronizes tunnel-signal handling and makes checksum conversion explicit. |
| source/HotspotApi/HotspotApi.c | Reports sysevent lookup failures during hotspot disable. |
| source/arp_solicitation/hotspot_arpd.c | Checks MAP-T lookups and clears closed sysevent connection state. |
Review effort: Balanced
… component
Reason for change: Fixing Coverity issue linked in Jira
Test Procedure: Should meet Acceptance Criteria:
Risks: Medium
Priority: P1