Skip to content

RDKB-67402: [Coverity] Fix High and Medium Priority issues in hotspot… - #74

Open
Deepak-Rathn wants to merge 1 commit into
developfrom
coverity/RDKB-67402
Open

Deepak-Rathn wants to merge 1 commit into
developfrom
coverity/RDKB-67402

Conversation

@Deepak-Rathn

Copy link
Copy Markdown

… component

Reason for change: Fixing Coverity issue linked in Jira
Test Procedure: Should meet Acceptance Criteria:
Risks: Medium
Priority: P1

… component

Reason for change: Fixing Coverity issue linked in Jira
Test Procedure: Should meet Acceptance Criteria:
Risks: Medium
Priority: P1

Signed-off-by: Deepak-Rathn <deepak.rathn@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 07:57
@Deepak-Rathn
Deepak-Rathn requested review from a team as code owners October 22, 2026 07:57
@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The tunnel-signaling synchronization changes need concurrency and failover validation before approval.

No open issues 🎉

What changed in this PR

This PR addresses Coverity findings in the hotspot component, focusing on tunnel-signal synchronization, sysevent error handling, and resource cleanup.

Changes:

  • Protect primary and secondary tunnel-signal consumption with a mutex and explicitly mask the checksum result.
  • Check sysevent return values in hotspot disable and MAP-T address lookup paths.
  • Reset the ARP daemon’s sysevent descriptor and token after closing the connection.
File Description
source/​hotspotfd/​hotspotfd.c Synchronizes tunnel-signal handling and makes checksum conversion explicit.
source/​HotspotApi/​HotspotApi.c Reports sysevent lookup failures during hotspot disable.
source/​arp_solicitation/​hotspot_arpd.c Checks MAP-T lookups and clears closed sysevent connection state.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants