Repository navigation
Conversation
Release 2.6.0 2.6.0
Reason for change: Initialize the hotspot command buffer and execute it only when commands were appended. This prevents stale Buffer 2 contents from being passed to the shell when hotspot bridges are managed through CORE_NET_LIB. Test Procedure: Hotspot should be running with no new error. Risks: Medium Priority: P1 Signed-off-by: Sriraaman C <sriraaman33@gmail.com>
…d Hotspot clients due to DHCP failure (#69) RDKCOM-5639:Add a marker string to monitor Disassociated Hotspot clients due to DHCP failure Reason for change: Add a marker string to monitor Disassociated Hotspot clients due to DHCP failure Test Procedure: 1. Change the endpoint ip address and make sure Wag doen't respond to DHCP discover. dmcli eRT setv Device.X_COMCAST-COM_GRE.Tunnel.1.PrimaryRemoteEndpoint string 75.75.75.75 dmcli eRT setv Device.X_COMCAST-COM_GRE.Tunnel.1.SecondaryRemoteEndpoint string 75.75.76.76 2. Marker string will be logged in /rdklogs/logs/Hotspotlog.txt.0 file if hotspot client doesn't get the ip from WAG Risks : None Priority : P2
Reason for change: Remove GitHub token from native-build workflow. Test Procedure: All checks should pass. Risks: Low Priority: P1 Signed-off-by: Sowmiya_Chelliah@comcast.com
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
6 open findings
offset > 0avoids executing an empty buffer, but it still allows executing a… · Newoffset > 0avoids executing an empty buffer, but it still allows executing a… · New
What changed in this PR
Updates hotspot telemetry and command execution safety, and removes a sensitive token from CI configuration.
Changes:
- Emit a telemetry marker when DHCP fails and the client is disassociated.
- Prevent executing hotspot commands when the command buffer is empty.
- Remove a GitHub token export from the native-build workflow and update the changelog for a new release.
| File | Description |
|---|---|
| source/hotspotfd/dhcpsnooper.c | Adds a telemetry/log marker for DHCP failure + disassociation events. |
| source/HotspotApi/HotspotApi.c | Initializes command buffer and avoids executing an empty command. |
| CHANGELOG.md | Reworks release notes to include a 2.7.0 section and related items. |
| .github/workflows/native-build.yml | Removes exporting a GitHub token as an env var in CI. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+9
| #### 2.7.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#71`](https://github.com/rdkcentral/hotspot/pull/71) |
Comment on lines
+35
to
+36
| - Coverity fixes for hotspot repo [`75d154a`](https://github.com/rdkcentral/hotspot/commit/75d154a3d18a5f18ca3875c1fc75b826615b1b11) | ||
| - Update tunnelcheck.c [`6c27bf8`](https://github.com/rdkcentral/hotspot/commit/6c27bf8f188afe7fd33800b5ffa3fd46e7c86e97) |
Comment on lines
+631
to
632
| char cmdBuf[1024] = {0}; | ||
| int offset = 0; |
Comment on lines
+833
to
+835
| if (offset > 0) { | ||
| sys_execute_cmd(cmdBuf); | ||
| } |
Comment on lines
+1241
to
+1245
| char telemetry_buf[18] = {'\0'}; | ||
| //Added marker to track the disassociated client upon DHCP failure | ||
| CcspTraceInfo(("DHCP_FAILED_AND_CLIENT_DISASSOCIATED: %s\n",mac_str)); | ||
| snprintf(telemetry_buf, sizeof(telemetry_buf), "%s", mac_str); | ||
| t2_event_s("DHCP_FAILED_AND_CLIENT_DISASSOCIATED", telemetry_buf); |
| #### [2.6.0](https://github.com/rdkcentral/hotspot/compare/2.5.0...2.6.0) | ||
| #### 2.7.0 | ||
|
|
||
| - RDKB-67262: Remove Github token from Native build [`#71`](https://github.com/rdkcentral/hotspot/pull/71) |
|
📋 PR Format Reminder
Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.7.0