Skip to content

Feature/cord 2025q4 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smamidi2011 wants to merge 40 commits into
base: develop
Choose a base branch
from
Open

Feature/cord 2025q4 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
bc091d4
Revert "Merge pull request #32 from jonathanwu-csv/develop"
bunnam988 Nov 18, 2025
2011dda
Revert "Merge pull request #29 from madhukrishnasmenon-comcast/develop"
bunnam988 Nov 18, 2025
ec4426f
Revert "Merge pull request #19 from ldalek/ow_threads_stack_sizes"
bunnam988 Nov 18, 2025
e0b3fc2
Reapply "Merge pull request #19 from ldalek/ow_threads_stack_sizes"
bunnam988 Dec 5, 2025
40c402a
Merge pull request #40 from Gowthamik93/XB9-669
apattu200 Nov 18, 2025
852b295
Implement PSM APIs using CORD #53
madhukrishnasmenon-comcast Apr 1, 2026
2c85db5
Implement PSM APIs using CORD
Apr 2, 2026
825bb0b
Add definition for safe_atou
madhukrishnasmenon-comcast Apr 8, 2026
b3d875b
Adding cord open and close
madhukrishnasmenon-comcast Apr 12, 2026
4c8365a
Apply suggestion from @Copilot
lucienkennedylamb Apr 20, 2026
038d7db
Implement PSM APIs using CORD
Apr 22, 2026
7098b22
Implement PSM APIs using CORD
Apr 28, 2026
834fbd2
Implement PSM APIs using CORD
Apr 28, 2026
7c5522d
Merge branch 'feature/CORD-2025q4' of github.com:rdkcentral/common-li…
madhukrishnasmenon-comcast Apr 28, 2026
5afe9ca
Implement PSM APIs using CORD
Apr 29, 2026
fa309a5
Implement PsmGroupGet Api
May 5, 2026
c53aa1a
Update ccsp_base_api.c
smamidi2011 May 8, 2026
739c056
Update ccsp_base_api.c
smamidi2011 May 21, 2026
75c3e55
updating Psm service to run after cord daemon is up
madhukrishnasmenon-comcast Jun 10, 2026
79046c1
fix(psm): handle root PsmEnumRecords path for dumpall output
madhukrishnasmenon-comcast Jun 15, 2026
764881c
fix(cord): report PSM health as Green via psm_initialized sentinel
madhukrishnasmenon-comcast Jun 15, 2026
a171392
cord_list() takes a data namespace path (e.g. "dmsb.", ""), not a rbu…
madhukrishnasmenon-comcast Jun 15, 2026
c09fc4b
Update ccsp_base_api.c
smamidi2011 Jun 18, 2026
71f3ee8
feat(psm): add call-count tracing to PSM CORD APIs
madhukrishnasmenon-comcast Jul 14, 2026
a9c7877
feat(psm): add ns-resolution timing to PSM API call tracer
madhukrishnasmenon-comcast Jul 30, 2026
66c05d2
fix(psm): fix PSM_CORD_COUNT timing scope — do-while ended cleanup to…
madhukrishnasmenon-comcast Jul 31, 2026
83654a3
feat(psm): use per-PID trace files to avoid cross-process overwrite
madhukrishnasmenon-comcast Jul 31, 2026
b47a266
feat(psm): print the process name in the per-PID trace files
madhukrishnasmenon-comcast Aug 10, 2026
6831159
feat(psm): print the record name in the per-PID trace files
madhukrishnasmenon-comcast Aug 10, 2026
765bc94
bug(psm): Adding debug prints for PsmGetNextLevelInstances
madhukrishnasmenon-comcast Sep 5, 2026
33077a7
bug(psm): passing pParentPath to cord_list
madhukrishnasmenon-comcast Sep 5, 2026
592d979
bug(psm): fixed safe_atou
madhukrishnasmenon-comcast Sep 5, 2026
2ac374d
bug(psm): removing debug prints
madhukrishnasmenon-comcast Sep 6, 2026
e47793f
bug(psm): 1. returning callbackerror if any one instance is not CORD_…
madhukrishnasmenon-comcast Sep 6, 2026
f4f0414
bug(psm): debug prints for PsmEnumRecords
madhukrishnasmenon-comcast Sep 16, 2026
3d7e6b2
bug(psm): remove debug prints
madhukrishnasmenon-comcast Sep 17, 2026
9c1d2ac
bug(psm): fix record delete and bool value case in CORD
madhukrishnasmenon-comcast Oct 20, 2026
32dd454
feat(psm): add PSM API latency benchmark for CORD comparison
madhukrishnasmenon-comcast Oct 29, 2026
3a40d2d
feat(psm): add -f option and delete failure diagnostic to speed test
madhukrishnasmenon-comcast Oct 29, 2026
df059ac
bug(psm): use psmcli default prefix in speed test
madhukrishnasmenon-comcast Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,19 @@ AC_ARG_ENABLE([gtestapp],
[echo "Gtestapp is disabled"])
AM_CONDITIONAL([WITH_GTEST_SUPPORT], [test x$GTEST_SUPPORT_ENABLED = xtrue])

AC_ARG_ENABLE([cord],
AS_HELP_STRING([--enable-cord],[enable CORD persistent storage support (default is no)]),
[
case "${enableval}" in
yes) CORD_ENABLED=true
CFLAGS="$CFLAGS -DCORD_ENABLED";;
no) CORD_ENABLED=false;;
*) AC_MSG_ERROR([bad value ${enableval} for --enable-cord]);;
esac
],
[CORD_ENABLED=false])
AM_CONDITIONAL([WITH_CORD_SUPPORT], [test x$CORD_ENABLED = xtrue])

Comment on lines +43 to +55

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORD_ENABLED adds new references to cord_* APIs, but the build system here only appends -DCORD_ENABLED to CFLAGS; there’s no library detection/linking (e.g., AC_CHECK_LIB / pkg-config) and WITH_CORD_SUPPORT isn’t referenced elsewhere. As-is, --enable-cord is likely to compile but fail to link (undefined references) or not propagate link flags to the relevant targets. Please add proper dependency checks and wire the conditional into Makefile.am to add the required include/lib flags.

Copilot uses AI. Check for mistakes.
AC_PREFIX_DEFAULT(`pwd`)
AC_ENABLE_SHARED
AC_DISABLE_STATIC
Expand Down
5 changes: 4 additions & 1 deletion scripts/ccsp_restart.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@ exec 3>&1 4>&2 >>$SELFHEALFILE 2>&1
fi
killall CcspLMLite
killall CcspXdnsSsp
if [ "$VOICE_SUPPORTED" != "false" ]; then
if [ -f "/tmp/mta_initialized" ]
then
rm -rf /tmp/mta_initialized
fi
killall CcspMtaAgentSsp
fi
killall CcspHotspot


Expand Down Expand Up @@ -174,6 +176,7 @@ ulimit -c unlimited

sleep 3
#mta
if [ "$VOICE_SUPPORTED" != "false" ]; then
if [ "$MODEL_NUM" = "DPC3939B" ] || [ "$MODEL_NUM" = "DPC3941B" ]; then
echo_t "Disabling MTA for BWG "
else
Expand All @@ -185,7 +188,7 @@ ulimit -c unlimited
$BINPATH/CcspMtaAgentSsp -subsys $Subsys
fi
fi

fi
sleep 3
echo "[`getDateTime`] RDKB_SELFHEAL : Resetting process webpa on atom reset"
cd /usr/ccsp/webpa
Expand Down
2 changes: 2 additions & 0 deletions scripts/cosa_start_arm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ if [ "x"$1 = "xkill" ] || [ "x"$2 = "xkill" ]; then
# killall CcspRmSsp
killall CcspCrSsp
# killall CcspLmSsp
if [ "$VOICE_SUPPORTED" != "false" ]; then
killall CcspMtaAgentSsp
fi
killall CcspCMAgentSsp
killall CcspLMLite
killall CcspXdnsSsp
Expand Down
3 changes: 2 additions & 1 deletion scripts/cosa_start_rem.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ syscfg set mgmt_wan_sshaccess 1
syscfg commit
echo_t "PWD is `pwd`"


if [ "$VOICE_SUPPORTED" != "false" ]; then
if [ "$MODEL_NUM" = "DPC3939B" ] || [ "$MODEL_NUM" = "DPC3941B" ]; then
echo_t "Disabling MTA for BWG "
else
Expand All @@ -212,6 +212,7 @@ if [ -e ./mta ]; then
cd ..
fi
fi
fi

if [ -e ./moca ]; then
cd moca
Expand Down
23 changes: 23 additions & 0 deletions source/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,3 +244,26 @@ libccsp_common_la_DEPENDENCIES = \


libccsp_common_la_LIBADD = $(libccsp_common_la_DEPENDENCIES)

# PSM API speed test: run on CORD and non-CORD images to compare per-API latency.
bin_PROGRAMS = psm_api_speed_test
psm_api_speed_test_SOURCES = psm_api_speed_test.c
psm_api_speed_test_CPPFLAGS = \
-I$(top_srcdir)/source/cosa/include/linux \
-I$(top_srcdir)/source/debug_api/include \
-I$(top_srcdir)/source/cosa/include \
-I$(top_srcdir)/source/cosa/utilities/include \
-I$(top_srcdir)/source/cosa/custom \
-I$(top_srcdir)/source/cosa/package/system/include \
-I$(top_srcdir)/source/cosa/package/slap/include \
-I$(top_srcdir)/source/cosa/package/slap/services/dslh/include \
-I$(top_srcdir)/source/ccsp/include \
-I$(top_srcdir)/source/ccsp/components/include \
-I$(top_srcdir)/source/ccsp/components/common/MessageBusHelper/include \
-I$(top_srcdir)/source/ccsp/components/common/PoamIrepFolder \
-I$(top_srcdir)/source/ccsp/custom \
-I$(top_srcdir)/source/util_api/ansc/include
psm_api_speed_test_LDADD = libccsp_common.la -ldbus-1 -lrbus -lrbuscore -lrtMessage -lpthread -lrt
if WITH_CORD_SUPPORT
psm_api_speed_test_LDADD += -lcord
endif
4 changes: 4 additions & 0 deletions source/ccsp/components/common/DataModel/dml/components/DslhObjController/dslh_objco_access.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,11 @@ DslhObjcoGetParamValueByName
/*AnscTraceVerbose(("DslhObjcoGetParamValueByName -- name %s\n", pName));*/

/* check whether it's a count of table (xxxNumberOfEntries) or not */
#ifdef _64BIT_ARCH_SUPPORT_
if(pSlapVariable->Syntax == (ULONG)SLAP_VAR_SYNTAX_uint32)
#else
if(pSlapVariable->Syntax == SLAP_VAR_SYNTAX_uint32)
#endif
{
pFind = _ansc_strstr(pName, TR69_NUMBER_OF_ENTRIES_STRING);

Expand Down
31 changes: 25 additions & 6 deletions source/cosa/utilities/AnscObjectArray/AnscUIntArray/ansc_uint_array_co_process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@


#include "ansc_uint_array_co_global.h"
#include <stdint.h>


/**********************************************************************
Expand Down Expand Up @@ -276,7 +275,11 @@ AnscUIntArrayGetAt

pStorage = (PUINT)pUIntArray->hStorage;

return (ANSC_OBJECT_ARRAY_DATA)(uintptr_t)pStorage[ulIndex];
#ifdef _64BIT_ARCH_SUPPORT_
return (ANSC_OBJECT_ARRAY_DATA)(ULONG)pStorage[ulIndex];
#else
return (ANSC_OBJECT_ARRAY_DATA)pStorage[ulIndex];
#endif
}

return (ANSC_OBJECT_ARRAY_DATA)NULL;
Expand Down Expand Up @@ -332,7 +335,11 @@ AnscUIntArraySetAt
PUINT pStorage;

pStorage = (PUINT)pUIntArray->hStorage;
pStorage[ulIndex] = (uintptr_t)Data;
#ifdef _64BIT_ARCH_SUPPORT_
pStorage[ulIndex] = (ULONG)Data;
#else
pStorage[ulIndex] = (UINT)Data;
#endif
}
}

Expand Down Expand Up @@ -413,7 +420,11 @@ AnscUIntArrayInsertAt

for (i = 0; i < ulCount; i ++)
{
pStorage[i + ulIndex] = (uintptr_t)Data;
#ifdef _64BIT_ARCH_SUPPORT_
pStorage[i + ulIndex] = (ULONG)Data;
#else
pStorage[i + ulIndex] = (UINT)Data;
#endif
}
}
}
Expand Down Expand Up @@ -528,7 +539,11 @@ AnscUIntArrayAdd
PUINT pStorage;

pStorage = (PUINT)pUIntArray->hStorage;
pStorage[pUIntArray->ulItemCount ++] = (uintptr_t)Data;
#ifdef _64BIT_ARCH_SUPPORT_
pStorage[pUIntArray->ulItemCount ++] = (ULONG)Data;
#else
pStorage[pUIntArray->ulItemCount ++] = (UINT)Data;
#endif

return pUIntArray->ulItemCount;
}
Expand Down Expand Up @@ -661,7 +676,11 @@ AnscUIntArrayFind
LONG Count = pUIntArray->ulItemCount;
LONG i;
PUINT pStorage = (PUINT)pUIntArray->hStorage;
UINT uSample = (uintptr_t)Data;
#ifdef _64BIT_ARCH_SUPPORT_
UINT uSample = (ULONG)Data;
#else
UINT uSample = (UINT)Data;
#endif

for (i = 0; i < Count; i ++)
{
Expand Down
2 changes: 1 addition & 1 deletion source/cosa/utilities/bsp_eng/bspeng_branch_co_process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ BspTemplateBranchLoadBranchData
if (!bSucc)
return FALSE;

pBrData->type = (BSP_TEMPLATE_BRANCH_TYPE)ucType;
pBrData->type = (BSP_TEMPLATE_OPERATOR)ucType;

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pBrData->type is declared as BSP_TEMPLATE_BRANCH_TYPE (see bspeng_co_interface.h), but this assignment casts ucType to BSP_TEMPLATE_OPERATOR instead. This changes the meaning of the persisted/loaded branch data and will break the subsequent switch over branch types. Cast to BSP_TEMPLATE_BRANCH_TYPE (as before) so the enum domain matches the field type.

Suggested change
pBrData->type = (BSP_TEMPLATE_OPERATOR)ucType;
pBrData->type = (BSP_TEMPLATE_BRANCH_TYPE)ucType;

Copilot uses AI. Check for mistakes.

Comment on lines +681 to 682

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pBrData->type is declared as BSP_TEMPLATE_BRANCH_TYPE (see bspeng_co_interface.h), but it’s being assigned by casting to BSP_TEMPLATE_OPERATOR. This mixes two unrelated enums and can produce invalid type values, breaking the subsequent switch. Please cast ucType to BSP_TEMPLATE_BRANCH_TYPE (or validate the byte value before assignment).

Suggested change
pBrData->type = (BSP_TEMPLATE_OPERATOR)ucType;
switch (ucType)
{
case BspBranch_eBranch:
case BspBranch_eString:
case BspBranch_eNumber:
case BspBranch_eReal:
case BspBranch_eVar:
case BspBranch_eArrayDim:
case BspBranch_eEmpty:
case BspBranch_eArrayItem:
case BspBranch_eApiParams:
pBrData->type = (BSP_TEMPLATE_BRANCH_TYPE)ucType;
break;
default:
return FALSE;
}

Copilot uses AI. Check for mistakes.
switch (pBrData->type)
{
Expand Down
14 changes: 11 additions & 3 deletions source/cosa/utilities/bsp_eng/bspeng_co_execute.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

**********************************************************************/

#include <stdint.h>

#include "bspeng_co_global.h"
#include "safec_lib_common.h"

Expand Down Expand Up @@ -6198,7 +6198,11 @@ BspTemplateEngGetSlapObjectString

if (pString)
{
rc = sprintf_s(pString, ulSize, "%.08X", (UINT)(uintptr_t)pSlapVar->Variant.varHandle);
#ifdef _64BIT_ARCH_SUPPORT_
rc = sprintf_s(pString, ulSize, "%.08X", (UINT)(ULONG)pSlapVar->Variant.varHandle);
#else
rc = sprintf_s(pString, ulSize, "%.08X", (UINT)pSlapVar->Variant.varHandle);
#endif
if(rc < EOK)
{
ERR_CHK(rc);
Expand Down Expand Up @@ -6417,7 +6421,11 @@ BspTemplateEngGetSlapObjectString
pString + AnscSizeOfString(pString),
ulSize+1,
(i == 0)? "%.08X" : ".%.08X",
(UINT)(uintptr_t)pArray->Array.arrayHandle[i]
#ifdef _64BIT_ARCH_SUPPORT_
(UINT)(ULONG)pArray->Array.arrayHandle[i]
#else
(UINT)pArray->Array.arrayHandle[i]
#endif
);
if(rc < EOK)
{
Expand Down
2 changes: 2 additions & 0 deletions source/debug_api/ansc_debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ const char *CcspTraceGetRdkLogModule(const char *pComponentName)
#if !defined (NO_MOCA_FEATURE_SUPPORT)
if (strcmp(pComponentName, "moca") == 0) return "LOG.RDK.MOCA";
#endif
#if !defined (NO_MTA_FEATURE_SUPPORT)
if (strcmp(pComponentName, "mta") == 0) return "LOG.RDK.MTA";
#endif
break;
case 'n':
#if defined (FEATURE_RDKB_NFC_MANAGER)
Expand Down
9 changes: 9 additions & 0 deletions source/debug_api/ansc_memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,8 +958,13 @@ AnscTraceMemoryTable2
sprintf
(
pTraceMessage,
#ifdef _64BIT_ARCH_SUPPORT_
" *** mem_block = %p, size = %9d bytes, id = %6d, %s ***",
pMemoryAllocItem->MemoryPointer,
#else
" *** mem_block = 0x%8X, size = %9d bytes, id = %6d, %s ***",
(UINT)pMemoryAllocItem->MemoryPointer,
#endif
(int)pMemoryAllocItem->MemorySize,
(int)pMemoryAllocItem->AllocId,
pMemoryAllocItem->OwnerDesp
Expand Down Expand Up @@ -1444,7 +1449,11 @@ void AnscLiveMemoryInspectRecordDetail

pPrevAllocItem = AnscGetPrevMemoryAllocItem(pMemoryBlock);

#ifdef _64BIT_ARCH_SUPPORT_
printf("found %p\n",pPrevAllocItem);
#else
printf("found %x\n",(UINT)pPrevAllocItem);
#endif

if ( !pPrevAllocItem )
{
Expand Down
Loading
Loading