Repository navigation
VPAAMP-22 [VIPA] AAMP returns duplicate CC text tracks on intra-asset encrypted assets - #1277
Conversation
|
@copilot Please review this code change. |
Agent-Logs-Url: https://github.com/rdkcentral/aamp/sessions/60a3eee3-2d5d-4874-8707-f5ebf04fef2d Co-authored-by: cpc005 <61162093+cpc005@users.noreply.github.com>
Reviewed the changes. Found a bug: in two places Also fixed the indentation of the continuation line in one of the |
There was a problem hiding this comment.
Pull request overview
This PR addresses duplicate closed-caption (CC) text tracks being reported for DASH (MPD) assets when multiple video AdaptationSets expose the same CC language, which caused repeated CC entries (e.g., in EPG/UI).
Changes:
- Add uniqueness filtering when collecting CC
TextTrackInfoentries so identical CC tracks are not duplicated. - Add functional tests covering manifests with repeated CC language entries across multiple AdaptationSets.
- Minor whitespace cleanup in existing test code/comments.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
fragmentcollector_mpd.h |
Declares helper for adding text tracks only when unique. |
fragmentcollector_mpd.cpp |
Implements uniqueness helper and uses it during CC accessibility parsing. |
test/utests/tests/StreamAbstractionAAMP_MPD/FunctionalTests.cpp |
Adds new L1 functional tests validating CC track de-duplication behavior. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rdkcentral/aamp/sessions/60a3eee3-2d5d-4874-8707-f5ebf04fef2d Co-authored-by: cpc005 <61162093+cpc005@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
17e6ca9 to
6122779
Compare

Reason for change: Multiple adaption sets each has same CC lang. Results in same CC lang being listed in EPG multiple times.