Skip to content

Update the main branch to add Actions - #11

Merged
MFransen69 merged 30 commits into
mainfrom
development/update-main-branch
Oct 16, 2026
Merged

MFransen69 merged 30 commits into
mainfrom
development/update-main-branch

Conversation

@VeithMetro

@VeithMetro VeithMetro commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Apart from the title, this PR also:

  • Renames WPEFramework to Thunder to make it compile with other main/master branches
  • Adds Actions for building on Linux

@VeithMetro VeithMetro changed the title Update the main branch with missing R4_4 commits Update the main branch to add Actions Oct 16, 2026
@VeithMetro
VeithMetro marked this pull request as ready for review October 16, 2026 09:03
Copilot AI lite review requested due to automatic review settings October 16, 2026 09:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical compilation and indefinite-blocking issues remain, along with CLI compatibility regressions.

4 open findings
What changed in this PR

Updates PluginActivator for Thunder and adds asynchronous activation with Linux GitHub Actions builds.

Changes:

  • Migrates framework references and CMake configuration to Thunder/C++17.
  • Adds configurable asynchronous plugin activation.
  • Adds reusable Linux build workflows and build-output ignores.
File Summary
source/​main.cpp CLI parsing and activation flow
source/​Log.cpp Formatting adjustment
source/​IPluginStarter.h Updated starter interface
source/​COMRPCStarter.h Asynchronous callback support
source/​COMRPCStarter.cpp Asynchronous activation implementation
CMakeLists.txt Thunder dependencies and C++17 configuration
.gitignore Ignores build output
.github/​workflows/​Linux build template.yml Reusable Linux build matrix
.github/​workflows/​Build ThunderPluginActivator on Linux.yml Thunder and plugin build workflow

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread source/COMRPCStarter.cpp
Comment thread source/IPluginStarter.h
Comment thread source/main.cpp
Comment thread source/main.cpp
@VeithMetro
VeithMetro requested a review from MFransen69 October 16, 2026 09:20
Copilot AI lite review requested due to automatic review settings October 16, 2026 09:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Multiple moderate correctness, compatibility, and build issues remain unresolved.

0 open findings

4 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Low severity README omits the new plugininitcallsign option

source/​main.cpp:42

This adds a user-visible --plugininitcallsign option, but the repository's README usage block still omits it and no longer matches the CLI help. Update the README usage/options so users can discover how to select a non-default activator callsign.

🧠 Review effort: Lite

@MFransen69
MFransen69 merged commit 7958944 into main Oct 16, 2026
31 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2026
@MFransen69
MFransen69 deleted the development/update-main-branch branch October 16, 2026 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants