Skip to content

RDKEMW-27311: Suppress Discovery.watched Events for Child/Teen/AgePolicy - #953

Merged
Vinodsathyaseelan merged 2 commits into
3.3.rcfrom
RDKEMW-27311
Oct 23, 2026
Merged

Vinodsathyaseelan merged 2 commits into
3.3.rcfrom
RDKEMW-27311

Conversation

@Vinodsathyaseelan

Copy link
Copy Markdown
Contributor

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copilot AI balanced review requested due to automatic review settings October 20, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The advertised watched-event suppression still needs runtime integration, or the PR scope must explicitly identify these changes as SDK prerequisites.

1 open issue
What changed in this PR

Adds SDK policy support toward suppressing Discovery.watched events for child and teen profiles.

Changes:

  • Adds optional profilePolicy metadata to discovery contexts.
  • Adds an age-policy predicate and unit tests.
  • Updates existing context initializers.
File Description
core/​sdk/​src/​api/​firebolt/​fb_lifecycle_management.rs Updates a test context initializer.
core/​sdk/​src/​api/​firebolt/​fb_discovery.rs Adds policy metadata, predicate, and tests.
core/​sdk/​src/​api/​device/​entertainment_data.rs Updates default and test contexts.
core/​sdk/​src/​api/​apps.rs Updates test context initializers.
core/​main/​src/​firebolt/​handlers/​actions_rpc.rs Updates handler test contexts.

Review effort: Balanced

Comment thread core/sdk/src/api/firebolt/fb_discovery.rs
Copilot AI balanced review requested due to automatic review settings October 20, 2026 23:13
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
core.main.src.broker.thunder 37% ❌
core.main.src.utils 28% ❌
device.thunder_ripple_sdk.src 13% ❌
core.main.src.bootstrap 0% ❌
core.main.src 0% ❌
core.sdk.src.extn.client 81% ✔
core.sdk.src.extn 76% ✔
core.sdk.src.utils 58% ➖
core.sdk.src.service.mock_app_gw.appgw 0% ❌
core.main.src.processor.storage 0% ❌
device.thunder_ripple_sdk.src.client 61% ➖
core.sdk.src.processor 9% ❌
core.main.src.processor 0% ❌
core.sdk.src.api 45% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
core.main.src.broker.test 90% ✔
device.thunder_ripple_sdk.src.processors.events 0% ❌
core.main.src.firebolt.handlers 13% ❌
core.main.src.service.extn 25% ❌
core.sdk.src.service.mock_app_gw 0% ❌
device.thunder_ripple_sdk.src.events 43% ❌
device.thunder_ripple_sdk.src.processors 19% ❌
core.main.src.broker.rules 78% ✔
core.main.src.bootstrap.manifest 0% ❌
core.main.src.state.cap 42% ❌
core.sdk.src.api.gateway 69% ➖
core.main.src.service.apps 36% ❌
core.sdk.src.manifest 0% ❌
core.main.src.bootstrap.extn 0% ❌
core.main.src.service 32% ❌
core.main.src.broker 69% ➖
core.sdk.src.extn.ffi 0% ❌
core.main.src.firebolt 13% ❌
core.main.src.service.ripple_service 9% ❌
core.main.src.state 36% ❌
core.sdk.src.api.distributor 29% ❌
core.sdk.src.service 65% ➖
core.sdk.src.api.manifest 74% ➖
core.tdk.src.gateway 100% ✔
core.sdk.src.api.device 76% ✔
core.tdk.src.utils 0% ❌
core.sdk.src.api.firebolt 85% ✔
core.sdk.src.api.observability 57% ➖
core.sdk.src.framework 64% ➖
device.mock_device.src 56% ➖
Summary 50% (22202 / 44465) ➖

Minimum allowed line rate is 48%

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues were identified in the scoped SDK additions and initializer updates; tests were inspected but not executed.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@Vinodsathyaseelan
Vinodsathyaseelan merged commit ef58885 into 3.3.rc Oct 23, 2026
9 checks passed
@Vinodsathyaseelan
Vinodsathyaseelan deleted the RDKEMW-27311 branch October 23, 2026 14:38
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants