Repository navigation
test - #1531
Open
Aniket0606 wants to merge 10 commits into
Open
test#1531Aniket0606 wants to merge 10 commits into
Aniket0606 wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Stream handling has unresolved type, numeric-validation, and output-integration issues.
4 open issues
What changed in this PR
This PR adds CSI stream-mode configuration across OneWifi’s bus and webconfig interfaces, alongside monitoring and math utility updates.
Changes:
- Adds OFF/FILE/LIVE stream settings and sample event subscriptions.
- Adds process CPU monitoring and lowers the minimum CSI interval.
- Corrects math calculations, capacity limits, and buffer handling.
| File | Description |
|---|---|
| source/webconfig/wifi_webconfig_csi.c | Logs the retained encoded buffer. |
| source/webconfig/wifi_encoder.c | Serializes Stream. |
| source/webconfig/wifi_decoder.c | Decodes and validates Stream. |
| source/utils/math_utils/src/vector.cpp | Corrects unsigned capacity handling. |
| source/utils/math_utils/src/sequence.cpp | Updates Gaussian calculations and initialization. |
| source/utils/math_utils/src/matrix.cpp | Caps column counts. |
| source/utils/math_utils/inc/matrix.h | Limits matrix capacities. |
| source/sampleapps/wifievents_consumer_sample.c | Adds Stream subscriptions and updates intervals. |
| source/core/wifi_ctrl.h | Declares stream state and CPU accessor. |
| source/core/wifi_ctrl.c | Adds process CPU monitoring. |
| source/core/Makefile.am | Links sensing builds with OpenSSL. |
| source/apps/wifi_sensing/src/motion_sensing.c | Adds a no-op webconfig event case. |
| source/apps/wifi_apps.c | Routes webconfig events to sensing. |
| source/apps/motion/wifi_motion.h | Adds Stream definitions and session state. |
| source/apps/motion/wifi_motion.c | Exposes Stream and bounds MAC-list concatenation. |
| source/apps/csi/wifi_csi_analytics.h | Adds analytics stream state. |
| source/apps/csi/wifi_csi_analytics.c | Aggregates requested stream modes. |
| include/wifi_base.h | Defines stream modes and reduces minimum interval. |
| configure.ac | Adds an external-delegate conditional. |
| config/subdoc_schemas_1_4/csi_data_subdoc_schema | Adds a Stream example field. |
Review effort: Balanced
Comment on lines
+281
to
+282
| if (new_csi_data->stream > csi_info->stream) { | ||
| csi_info->stream = new_csi_data->stream; |
| } | ||
|
|
||
| if (stream_mode != csi_data->stream) { | ||
| csi_data->stream = stream_mode; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.