Repository navigation
RDKB-63702: Adapt compatibility checks for BPi - #1528
Merged
gsathish86 merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Encryption mismatches can remain grouped, and default BPi link IDs can prevent radio-triggered membership updates.
2 open issues
What changed in this PR
Extends MLO compatibility checks to Banana Pi so participating VAPs maintain consistent settings.
Changes:
- Enables generic-MLO validation during initialization and configuration updates.
- Selects compatible VAP groups without a designated main link.
- Explicitly disables MLO for non-private BPi VAP defaults.
| File | Description |
|---|---|
| source/db/wifi_db.c | Sets non-private VAP MLO defaults. |
| source/db/wifi_db_apis.c | Applies matching database API defaults. |
| source/core/wifi_ctrl.h | Exposes group validation for generic MLO. |
| source/core/wifi_ctrl.c | Adds generic-MLO initialization and compatibility grouping. |
| source/core/wifi_ctrl_webconfig.c | Enables validation and radio-triggered reconfiguration for generic MLO. |
Review effort: Balanced
mateuszCieslak-GL
force-pushed
the
develop
branch
from
October 19, 2026 15:39
3bfd28a to
8c99875
Compare
mateuszCieslak-GL
force-pushed
the
compatibility-checks-bpi
branch
from
October 19, 2026 22:08
7be3d88 to
8c6dd3d
Compare
bmilcz-comcast
force-pushed
the
compatibility-checks-bpi
branch
from
October 20, 2026 13:27
8c6dd3d to
0b1bacd
Compare
Reason for change: MLO on BPi shares same high-level requirements with regard to unified setting across participants. Commit adapts current way of compatibility checks in order to maintain the settings. Test procedure: Change setting of VAPs partaking in MLD and see if the change is according to expectations (exclusion/addition). Risks: None Priority: P1 Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
bmilcz-comcast
force-pushed
the
compatibility-checks-bpi
branch
from
October 21, 2026 06:58
0b1bacd to
1a9e0ea
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Persisted legacy defaults and per-radio updates can produce incorrect MLO membership.
5 open issues
Review effort: Balanced
mateuszCieslak-GL
approved these changes
Oct 21, 2026
bmilcz-comcast
changed the title
Contributor
🔨 Build summaryCommit Banana Pi R4 - MLO — build success
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: MLO on BPi shares same high-level requirements with regard to unified setting across participants. Commit adapts current way of compatibility checks in order to maintain the settings.
Test procedure: Change setting of VAPs partaking in MLD and see if the change is according to expectations (exclusion/addition).
Risks: None
Priority: P1