[Kondamma12345]

Harden WiFi API JSON file reads by validating file type and size before memory allocation and read.

[Copilot]

Copilot review overview

🟡 Changes recommended

The wifi_createVAP short-read path leaks an open file descriptor.

Review effort: Balanced
Findings: 1

Open (1)

• Close json_file before handling short fread · New

What changed in this PR

Hardens WiFi API JSON loading by validating file type, enforcing a size limit, and detecting incomplete reads.

Changes:

• Rejects non-regular, empty, or oversized JSON files.
• Uses zero-initialized bounded allocations.
• Validates complete file reads.

File	Description
source/​core/​wifi_ctrl_wifiapi_handlers.c	Adds safer JSON file validation and loading.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟡 Changes recommended

Blocking file opens still allow FIFO paths to stall the WiFi controller indefinitely.

Review effort: Balanced
Findings: 1

Open (1)

• Blocking fopen of FIFO prevents non-regular file rejection · New

Resolved since last review (1)

• Close json_file before handling short fread

[Copilot]

🔵 Needs a closer look

Human validation is still needed for the security-sensitive file-opening behavior and compatibility of the new size limit.

No open issues 🎉

1 resolved since last review

• Blocking fopen of FIFO prevents non-regular file rejection

_{Review effort: Balanced}