Fix PointsMaterial default vertexColors to fallback to material color… - #277
Open
rainerrodrigues wants to merge 1 commit into
Open
Fix PointsMaterial default vertexColors to fallback to material color…#277rainerrodrigues wants to merge 1 commit into
rainerrodrigues wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Issue #207 where point clouds with a specified
colorwould silently render as pitch black.The Bug:
The
PointsMaterialstruct hardcodedvertexColors = 2as the default. In Three.js, this forces the engine to look for an array of per-vertex colors attached to the geometry. If the user only passed coordinates (without a matching color array), Three.js would fall back to black, completely overriding the material'scolorargument.The Fix:
Changed the default
vertexColorsvalue from2to0. This allows the material to properly default to thecolorkwarg (which defaults to white, or whatever the user specifies) while still allowing users to explicitly opt-in to per-vertex coloring if they need it.