Automate visibility tracks for setobject! in atframe to allow object … - #273
Open
rainerrodrigues wants to merge 1 commit into
Open
Automate visibility tracks for setobject! in atframe to allow object …#273rainerrodrigues wants to merge 1 commit into
rainerrodrigues wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially added a helpful error message to prevent silent failures here, but after looking deeper into the Three.js constraints, I realized we can actually fulfill the feature request! I've updated the PR to automate visible boolean tracks. Now, if a user calls setobject! inside an atframe block, it creates the object globally but automatically hides it at frame 0 and makes it visible at the requested frame.