Repository navigation
fix(result_builder): match single-test results to discovered IDs - #339
Merged
Merged
Conversation
rcasia
marked this pull request as ready for review
September 30, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #338.
JUnit Vintage reports a plain method as
demo, while discovery identifies it asdemo(). Previously, the single-testcase branch returned the report ID directly, leaving Neotest unable to associate a passing result with the discovered test node. A parameterized method with only one invocation had the same problem.Verification
make test: all 194 cases pass.stylua --check .: passes.lua-language-server --check .: no problems found.The PR remains a draft; it now includes the production fix as well as the regression tests.