Repository navigation
Conversation
rcasia
marked this pull request as ready for review
September 23, 2026 10:57
rcasia
marked this pull request as draft
September 23, 2026 11:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor (no behavior change) preparing for #314 (IntelliJ LSP).
Introduces a single replaceable seam,
JavaLanguageServer(lua/neotest-java/core/language_server/), exposing exactly three domain methods:get_java_home(cwd)(was inlinejava.project.getSettingsincommand/binaries.lua)get_classpath(base_dir, extra?)(was inlinejava.project.getClasspathsinclasspath_provider.lua)compile(opts)(was inlinejava/buildWorkspaceinlsp_compiler.lua)The jdtls side is three single-purpose resolvers behind a thin facade;
Binaries,ClasspathProvider, andLspCompilerare now thin delegates with unchanged signatures. Public DI gains one optionallanguage_serveroverride (explicit component overrides still win per-concern; legacyclient_providercomposes into the default jdtls gateway), so existing configs work unchanged.A future IntelliJ implementation only adds a gateway with the same three methods — no changes to SpecBuilder/MethodIdResolver.
Checks:
make testgreen,stylua --check,luacheck,lua-language-server --checkclean.