Coderabbit review - #1
Conversation
Add notes to classificatio process overview to clarifying timing of host reservation class assignment.
new file: changelog_unreleased/4011-kea-dhcp6-client-ip-reservation-inconsistently-assigned modified: doc/sphinx/arm/hooks-flex-id.rst modified: src/hooks/dhcp/flex_id/flex_id_messages.cc modified: src/hooks/dhcp/flex_id/flex_id_messages.h modified: src/hooks/dhcp/flex_id/flex_id_messages.mes modified: src/hooks/dhcp/flex_id/libloadtests/load_unload_unittests.cc modified: src/hooks/dhcp/flex_id/load_unload.cc
modified: src/hooks/dhcp/flex_id/flex_id_messages.mes
modified: changelog_unreleased/4011-kea-dhcp6-client-ip-reservation-inconsistently-assigned modified: doc/sphinx/arm/hooks-flex-id.rst
/src/bin/dhcp4/dhcp4_messages.mes
Updated mesage descriptions
/src/bin/dhcp4/dhcp4_srv.cc
Add verbose=true to Pkt4::toText() calls
/src/lib/dhcp/pkt.h
Pkt::toText() - added verbose flag
/src/lib/dhcp/pkt4.*
Pkt4::toText() - added verbose logic
/src/lib/dhcp/pkt6.*
Pkt6::toText() - added vebose parameter (unused)
/src/lib/dhcp/tests/pkt4_unittest.cc
TEST_F(Pkt4Test, toTextVerbose) - new test
/src/lib/util/str.*
printOrDump() - new function
/src/lib/util/tests/str_unittests.cc
TEST_F(StringUtilTest, printOrDump) - new test
modified: src/bin/dhcp4/dhcp4_messages.mes modified: src/lib/util/str.cc modified: src/lib/util/tests/str_unittests.cc
modified: src/bin/agent/agent_lexer.cc modified: src/bin/d2/d2_lexer.cc modified: src/bin/dhcp4/dhcp4_lexer.cc modified: src/bin/dhcp6/dhcp6_lexer.cc modified: src/lib/eval/lexer.cc
modified: src/lib/util/str.cc
modified: src/lib/util/str.cc modified: src/lib/util/tests/str_unittests.cc
…nd flex under docs
…|| echo 1' to make sure all compilations are fast
new file: changelog_unreleased/4086-password-leaked-to-logs
/src/lib/asiolink/process_spawn.*
ProcessSpawnImpl::getCommandLine() - modified to accept
ProcessSpawn::getCommandLine() - modified to accept
a list of arguments whose values should be redacted
/src/lib/asiolink/tests/process_spawn_unittest.cc
TEST_F(ProcessSpawnTest, getCommandLineRedacted) - new test
/src/lib/mysql/mysql_connection.cc
MySqlConnection::initializeSchema() - add list of args to redact to
getCommandLine() call
/src/lib/pgsql/pgsql_connection.cc
PgSqlConnection::initializeSchema() - add list of args to redact to
getCommandLine() call
modified: changelog_unreleased/4086-password-leaked-to-logs modified: src/lib/asiolink/process_spawn.cc modified: src/lib/asiolink/tests/process_spawn_unittest.cc modified: src/lib/mysql/mysql_connection.cc modified: src/lib/pgsql/pgsql_connection.cc
src/lib/asiolink/process_spawn.cc
User count() instead of contains()
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 122 files out of 232 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests✅ Unit Test PR creation complete.
Comment |
razvan-becheriu
left a comment
razvan-becheriu
left a comment
There was a problem hiding this comment.
@coderabbitai full review
|
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
✅ UTG Post-Process Complete No new issues were detected in the generated code and all check runs have completed. The unit test generation process has completed successfully. |
|
Creating a PR to put the unit tests in... The changes have been created in this pull request: View PR |
|
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
|
✅ UTG Post-Process Complete No new issues were detected in the generated code and all check runs have completed. The unit test generation process has completed successfully. |
|
Creating a PR to put the unit tests in... The changes have been created in this pull request: View PR |
6 participants
No description provided.