Skip to content

fix(sdk): add icons to PAT details header action menu#1635

Merged
rohanchkrabrty merged 1 commit into
mainfrom
fix-pat-icon
May 20, 2026
Merged

fix(sdk): add icons to PAT details header action menu#1635
rohanchkrabrty merged 1 commit into
mainfrom
fix-pat-icon

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Added leading icons to the action menu items in the PAT details view header for visual consistency with team/project/service-account detail views.
  • Update uses Pencil1Icon, Regenerate uses UpdateIcon, and Revoke uses the shared delete.svg asset — matching icon usage elsewhere in views-new.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 20, 2026 8:56am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Enhanced Personal Access Token (PAT) details menu with improved visual clarity by adding dedicated icons: a pencil icon for the Update action and a delete icon for the Revoke action.

Walkthrough

This PR adds visual icon assets to the PAT details view action menu. Icon imports (Pencil1Icon, Image component, and delete.svg) are added, then wired into the "Update" and "Revoke" menu items as leading icons with no changes to handlers, props, or component logic.

Changes

PAT Action Menu Icons

Layer / File(s) Summary
Action menu icon wiring
web/sdk/react/views-new/pat/pat-details-view.tsx
Imports are updated to include Pencil1Icon, UpdateIcon, Image, and delete.svg. The "Update" menu item renders Pencil1Icon as a leading icon; the "Revoke" menu item renders delete.svg as an Image with size and alt text. No changes to click handlers, test IDs, or component contract.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • Shreyag02
  • rsbh
  • rohilsurana
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty enabled auto-merge (squash) May 20, 2026 08:57
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35f50b35-aa32-46b3-9ead-55afe2e6232d

📥 Commits

Reviewing files that changed from the base of the PR and between 5061882 and 4dae599.

📒 Files selected for processing (1)
  • web/sdk/react/views-new/pat/pat-details-view.tsx

Comment thread web/sdk/react/views-new/pat/pat-details-view.tsx
@rohanchkrabrty rohanchkrabrty merged commit 0b6e31a into main May 20, 2026
8 checks passed
@rohanchkrabrty rohanchkrabrty deleted the fix-pat-icon branch May 20, 2026 09:01
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26152199215

Coverage remained the same at 42.592%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37953
Covered Lines: 16165
Line Coverage: 42.59%
Coverage Strength: 11.91 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants