fix(admin): use Radio for single-select role assignment#1631
Conversation
The org-level and project-level Assign Role dialogs were rendering Checkbox inputs for what is a single-select field (form schema and backend both accept only one roleId). This swaps them to Radio.Group + Radio, dropping the per-item dispatch helper that emulated radio semantics. API payloads are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughBoth the AssignRole component and assign-role view were refactored from checkbox-based multi-select role selection to single-select radio groups. Imports changed from Checkbox to Radio, checkbox handlers were removed, and role selection UI now uses Radio.Group bound to the form's roleId. ChangesRole Selection UI Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26203474805Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 42.592%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
Replaced
CheckboxwithRadio.Group+Radioin the single-select Assign Role dialogs:web/sdk/admin/components/AssignRole.tsx— org-level (org members tab, user details membership dropdown)web/sdk/admin/views/organizations/details/projects/members/assign-role.tsx— project-level (project members dialog)web/apps/admin/src/components/assign-role.tsxis genuinely multi-select and left as-is.API payloads unchanged.
Test plan
🤖 Generated with Claude Code