Repository navigation
[raycicmd] Give job containers the agent's name - #503
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the Docker plugin in raycicmd/bk_pipeline.go to include the add-host mapping for rayci.localhost:host-gateway, preventing DNS resolution failures during runtime pip installations. It also adds a corresponding unit test in raycicmd/bk_pipeline_test.go to verify this configuration. There are no review comments, and I have no additional feedback to provide.
elliot-barn
force-pushed
the
elliot-barn/jobenv-add-host
branch
from
August 20, 2026 21:19
66ce66c to
ef489c7
Compare
Wanda's docker build and ci/ray_ci/linux_container.py both pass --add-host rayci.localhost:host-gateway, so a service listening on the agent -- the package index proxy -- is reachable by the same name from an image build and from a test container. Containers that rayci starts through the docker buildkite plugin were the one launcher missing the mapping. That gap became visible when ray's CI images started baking the name into PIP_INDEX_URL (ray#65578, armed by ray#65605): any job_env step that runs pip at runtime resolves the baked index, fails DNS with "[Errno -5] No address associated with hostname", and dies. Observed on ray's doc API checks (via setuptools fetch_build_eggs), pyrefly type check, and pip-compile dependencies (direct runtime pip installs). The docker buildkite plugin v5.8.0 supports add-host natively, so this emits the same mapping unconditionally, matching the other two launchers. Agents where nothing listens on the name are unaffected: the entry only matters to a container that dials it. Signed-off-by: Ray CI Test <rayci@ray.io>
elliot-barn
force-pushed
the
elliot-barn/jobenv-add-host
branch
from
August 20, 2026 21:28
ef489c7 to
e38dcbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
add-host: rayci.localhost:host-gatewayto the docker buildkite plugin config thatmakeRayDockerPluginemits for job containers.Wanda's
docker build(#501) and ray'sci/ray_ci/linux_container.pyboth already pass this mapping, so a service listening on the agent — the package index proxy — is reachable by one stable name from an image build and from a test container. Containers rayci starts through the docker buildkite plugin were the one launcher missing it.The gap became visible when ray's CI images started baking the name into
PIP_INDEX_URL(ray-project/ray#65578, armed by ray-project/ray#65605): anyjob_envstep that runs pip at runtime resolves the baked index and fails DNS with[Errno -5] No address associated with hostname. Observed on ray'sdoc: check API annotations/check API doc consistency(via setuptoolsfetch_build_eggsfor cython),pyrefly type checkandbuild: pip-compile dependencies(direct runtime pip installs).The mapping is emitted unconditionally, matching the other two launchers. The docker buildkite plugin v5.8.0 supports
add-hostnatively (verified in its plugin.yml). Agents where nothing listens on the name are unaffected — the entry only matters to a container that dials it.Testing
TestMakeRayDockerPlugin_addHostasserts the emitted mapping.go test ./raycicmdpasses;go test ./...green except pre-existing local-env failures inraycilint(host git too old for--initial-branch), identical on cleanmain.Rollout note: after this merges and a release is cut, ray consumes it via
.rayciversion; thepyrefly type checkstep is a live canary since it still pip-installs at runtime.AI assistance (Claude Code) was used to prepare this change.
🤖 Generated with Claude Code