Repository navigation
[ci] Give the custom BYOD build a name for the agent - #65606
Merged
Merged
Conversation
Release 104848 failed hello_world_custom_byod.aws and .gce with
error: Request failed after 3 retries in 5.7s
Caused by: failed to lookup address information: No address
associated with hostname
Custom BYOD images are built by a plain `docker build` here, not by wanda, so
they inherit none of the --add-host rayci.localhost:host-gateway that wanda
passes every image build it starts (ray-project/rayci#501). The index build
arg is a name, the build has no way to resolve it, and install_python_deps.sh
resolves these depsets with uv, which errors where pip would have fallen back
-- so the image build fails outright rather than degrading to PyPI.
Passing the same flag here makes the two build paths address the agent
identically. Unconditional, as in wanda: docker resolves host-gateway itself,
and one hosts entry is inert for a build that never uses the name.
Signed-off-by: Elliot Barnwell <elliot.barnwell@anyscale.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the custom BYOD image build command in release/ray_release/byod/build.py to include the --add-host rayci.localhost:host-gateway flag. This change ensures that the plain docker build can resolve rayci.localhost to the host gateway, preventing dependency resolution failures during the build process. There are no review comments, so I have no feedback to provide.
nadongjun
pushed a commit
to nadongjun/ray
that referenced
this pull request
Oct 6, 2026
## What Passes `--add-host rayci.localhost:host-gateway` to the `docker build` that builds custom BYOD images, which is what wanda already passes to every image build it starts (ray-project/rayci#501). ## Why Release build 104848, on the commit that became ray-project#65578, failed `hello_world_custom_byod.aws` and `hello_world_custom_byod.gce`: ``` ray-project#11 6.043 error: Request failed after 3 retries in 5.7s ray-project#11 6.043 Caused by: failed to lookup address information: No address associated with hostname ray-project#11 ERROR: process "/bin/bash -c bash /tmp/install_python_deps.sh python_depset.lock" did not complete successfully: exit code: 2 ``` Custom BYOD images are built here by a plain `docker build`, not by wanda, so they inherit none of wanda's networking flags. `RAYCI_IMAGE_PIP_INDEX_URL` reaches the build as `http://rayci.localhost:35999/simple` — a name the build has no way to resolve — and `install_python_deps.sh` resolves the depsets with **uv**, which fails hard where pip would have fallen back to PyPI. So the image build dies rather than degrading. Everything else on that build was green (78 passed at the time, including `wanda: forge`, all five wheel builds, the `base-extra-testdeps` images, and the `hello_world*` release tests on AWS, GCE and released images) — this is the one path that reaches the agent proxy without going through wanda. Unconditional, matching wanda: docker resolves `host-gateway` itself, and one extra hosts entry is inert for a build that never uses the name. ## Testing `python -m pytest release/ray_release/tests/test_byod_build.py` — 4 passed. The flag goes in after `-t <image>`, so the argument prefix those tests match on is unchanged. AI assistance was used for this change. Signed-off-by: Elliot Barnwell <elliot.barnwell@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Passes
--add-host rayci.localhost:host-gatewayto thedocker buildthat builds custom BYOD images, which is what wanda already passes to every image build it starts (ray-project/rayci#501).Why
Release build 104848, on the commit that became #65578, failed
hello_world_custom_byod.awsandhello_world_custom_byod.gce:Custom BYOD images are built here by a plain
docker build, not by wanda, so they inherit none of wanda's networking flags.RAYCI_IMAGE_PIP_INDEX_URLreaches the build ashttp://rayci.localhost:35999/simple— a name the build has no way to resolve — andinstall_python_deps.shresolves the depsets with uv, which fails hard where pip would have fallen back to PyPI. So the image build dies rather than degrading.Everything else on that build was green (78 passed at the time, including
wanda: forge, all five wheel builds, thebase-extra-testdepsimages, and thehello_world*release tests on AWS, GCE and released images) — this is the one path that reaches the agent proxy without going through wanda.Unconditional, matching wanda: docker resolves
host-gatewayitself, and one extra hosts entry is inert for a build that never uses the name.Testing
python -m pytest release/ray_release/tests/test_byod_build.py— 4 passed. The flag goes in after-t <image>, so the argument prefix those tests match on is unchanged.AI assistance was used for this change.