Repository navigation
fix: preserve registered symbols with empty identifiers - #363
Open
LucasLeao18 wants to merge 1 commit into
Open
LucasLeao18 wants to merge 1 commit into
LucasLeao18 wants to merge 1 commit into
Conversation
|
This PR does not match any of the 1 configured review trigger rule. |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering Symbol() or Symbol('') generates an empty identifier. Truthiness checks then treat the symbol as unregistered, so stringify/parse drops it, and a subsequent registration can replace its existing identifier.
Check for undefined explicitly in the transformation rule and registry. Cover nested and root round-trips and repeated registration.
Validation (Node.js 24.15.0, Windows): The added round-trip regression fails before the fix. npm test -- --threads=false: 87 passing, 1 skipped, 1 todo; npm run build passes.
AI assistance: this contribution was prepared with OpenAI Codex; the change and regression results were reviewed before submission.