Skip to content

misc: rp1-pio: release DMA channel outside pio->lock #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 1 commit into from
Jul 22, 2026
+6 −1
Merged

misc: rp1-pio: release DMA channel outside pio->lock #7513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion drivers/misc/rp1-pio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ static int rp1_pio_sm_config_xfer_internal(struct rp1_pio_client *client, uint s
struct dma_info *dma = NULL;
uint32_t dma_mask;
char chan_name[4];
bool reconfigure = false;
int ret = 0;

if (sm >= RP1_PIO_SMS_COUNT || dir >= RP1_PIO_DIR_COUNT)
Expand All @@ -633,14 +634,18 @@ static int rp1_pio_sm_config_xfer_internal(struct rp1_pio_client *client, uint s
if (!(pio->claimed_dmas & dma_mask & ~client->claimed_dmas)) {
dma = &pio->dma_configs[sm][dir];
if (client->claimed_dmas & dma_mask)
rp1_pio_sm_dma_free(dev, dma);
reconfigure = true;
pio->claimed_dmas |= dma_mask;
client->claimed_dmas |= dma_mask;
}
spin_unlock(&pio->lock);
if (!dma)
return -EBUSY;

/* dma_release_channel() sleeps, so free the old channel outside the lock. */
if (reconfigure)
rp1_pio_sm_dma_free(dev, dma);

dma->buf_size = buf_size;
/* Round up the allocations */
buf_size = ROUND_UP(buf_size, PAGE_SIZE);
Expand Down
Loading