Skip to content

Fetch rapids-cmake cmake-format with GitHub authentication - #2479

Merged
rapids-bot[bot] merged 4 commits into
rapidsai:mainfrom
bdice:agent/check-style-gh-auth
Oct 17, 2026
Merged

rapids-bot[bot] merged 4 commits into
rapidsai:mainfrom
bdice:agent/check-style-gh-auth

Conversation

@bdice

@bdice bdice commented Jul 9, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This is a fix for the style check download failure observed in #2476: https://github.com/rapidsai/rmm/actions/runs/28987611693/job/86020175188

--2026-07-09 01:29:50--  https://raw.githubusercontent.com/rapidsai/rapids-cmake/main/cmake-format-rapids-cmake.json
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.111.133, 185.199.108.133, 185.199.109.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.111.133|:443... connected.
HTTP request sent, awaiting response... 429 Too Many Requests
2026-07-09 01:29:53 ERROR 429: Too Many Requests.

This updates ci/check_style.sh to fetch cmake-format-rapids-cmake.json through the GitHub contents API with gh api when available. The existing unauthenticated wget download remains as the fallback.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice requested a review from a team as a code owner July 9, 2026 05:46
@bdice
bdice requested a review from KyleFromNVIDIA July 9, 2026 05:46
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2026
@bdice bdice self-assigned this Jul 9, 2026
@bdice bdice moved this to In Progress in RMM Project Board Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rapidsai/rmm/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 774894c7-79dc-454a-bc67-a5660533baf6
📥 Commits

Reviewing files that changed from the base of the PR and between e1173e1 and dc4903a.

📒 Files selected for processing: 1
  • ci/check_style.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the copyright notice to cover 2020–2026 and name NVIDIA Corporation and its affiliates.
    • Updated style-check configuration retrieval to use the RAPIDS fetch utility with the configured branch.
    • These changes affect project attribution and the style-check setup; they do not change user-facing functionality.

ci/check_style.sh updates its SPDX copyright notice and retrieves the style configuration with rapids-github-fetch, using RAPIDS_BRANCH.

Changes: CI style check script update

Layer / File(s) Summary
Style configuration retrieval and copyright notice
ci/check_style.sh
The script uses rapids-github-fetch with RAPIDS_BRANCH to retrieve the style configuration. The SPDX copyright notice now covers 2020–2026 and names NVIDIA Corporation & Affiliates.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to dc490

The style-check runtime provisions the new fetch helper, so this change does not leave the check dependent on an unavailable command. No actionable merge risk remains.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: authenticated fetching of the rapids-cmake cmake-format configuration.
Description check Passed The description directly explains the style-check download failure and the authenticated fetch change, which matches the pull request changeset and objectives.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please make this change in cudf (and other repos with this fetch in place) too. Thanks!

@bdice

bdice commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

I want to refactor the gh call into a helper in gha-tools. Here is a PR adding rapids-github-fetch: rapidsai/gha-tools#280

rapids-bot Bot pushed a commit to rapidsai/gha-tools that referenced this pull request Oct 15, 2026
Motivated by rapidsai/rmm#2479. This will reduce our number of calls that count against the unauthenticated rate limit for our CI systems' IP ranges.

Adds `rapids-github-fetch`, which prints a file from a GitHub repository to stdout. It tries an authenticated `gh api` request first, then falls back to `wget`, then `curl` against raw.githubusercontent.com.

```bash
rapids-github-fetch rapidsai/rapids-cmake cmake-format-rapids-cmake.json "${RAPIDS_BRANCH}" > cmake-format-rapids-cmake.json
```

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #280

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this change, thank you

@jameslamb
jameslamb removed the request for review from KyleFromNVIDIA October 16, 2026 19:57
@bdice

bdice commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 91aa4a7 into rapidsai:main Oct 17, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in RMM Project Board Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants